[Libreoffice-commits] core.git: forms/source

[Julien Nabet (via logerrit)]

 forms/source/xforms/datatypes.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4829a85d0753c93419bd46b1d50bcfa6f0f3f1da
Author:     Julien Nabet <serval2...@yahoo.fr>
AuthorDate: Fri Apr 14 21:05:06 2023 +0200
Commit:     Julien Nabet <serval2...@yahoo.fr>
CommitDate: Fri Apr 14 22:58:09 2023 +0200

    tdf#154734: XML Form doc: all binded fields will be shown as fields...
    
    with wrong content - except fields, which have wrong content
    
    Regression of 14cfff500e93f0d6cbf8412065feea85c01ea81d (at 2021-08-05)
    Pass context and resource string down to boost::locale separately
    because this is often on a hot path, and we can avoid the splitting and
    joining of strings like this.
    
    Before the commit, it was:
    return ( _validate( sValue ) == nullptr );
    
    _validate methods return "TranslateId" variable which contain the reason 
why validity is wrong
    so if this variable contains no reason it means everything is OK.
    
    so just replace:
    return bool(_validate( sValue ));
    by:
    return bool(!_validate( sValue ));
    
    Change-Id: I76373d0825f86f9072217c96757252b6a891ecc4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150433
    Reviewed-by: Julien Nabet <serval2...@yahoo.fr>
    Tested-by: Jenkins

diff --git a/forms/source/xforms/datatypes.cxx 
b/forms/source/xforms/datatypes.cxx
index 92e0c3ec781b..c372298f0e5f 100644
--- a/forms/source/xforms/datatypes.cxx
+++ b/forms/source/xforms/datatypes.cxx
@@ -156,7 +156,7 @@ namespace xforms
 
     sal_Bool OXSDDataType::validate( const OUString& sValue )
     {
-        return bool(_validate( sValue ));
+        return bool(!_validate( sValue ));
     }