i18npool/util/i18npool.component | 3 ---
1 file changed, 3 deletions(-)
New commits:
commit 7191ebc701074059bcfce01620c6035a299ffd78
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Wed Apr 5 21:25:58 2023 +0200
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Wed Apr 5 22:59:37 2023 +0200
Remove dead com.sun.star.i18n.Transliteration.ignoreKana service
implementation
In 2002, fc680b643030fc2c99dcfffe75e762ee35e5f292 "#97583# Modify for new
services" had added the two com.sun.star.i18n.Transliteration.IGNORE_KANA
and
com.sun.star.i18n.Transliteration.ignoreKana service implementations, both
using
the also added ignoreKana_CreateInstance factory function, to
i18npool/source/registerservices/registerservices.cxx (back in a time when
that
still used active component registration via component_writeInfo). Then in
2010
a3c8a0ed0c5c6be1cb5c940750222f6381608bd7 "sb129: #i113189# change UNO
components
to use passive registration" (dropping the active component registration via
component_writeInfo) faithfully listed both those service implementations in
i18npool/util/i18npool.component. And in 2014
a4f17c00b16f5a983cd91ac5d2c43454f1775931 "i18npool: Constructor feature for
few
more implementations" switched the
com.sun.star.i18n.Transliteration.IGNORE_KANA
service implementation to use a constructor attribute in
i18npool/util/i18npool.component. But it also removed from
i18npool/source/registerservices/registerservices.cxx the
ignoreKana_createInstance factory function and the
> IMPL_TRANSLITERATION_ITEM (ignoreKana),
aInstances element through which the other
com.sun.star.i18n.Transliteration.ignoreKana service implementation was
created
via i18npool_component_getFactory. (It presumably either intended to also
change com.sun.star.i18n.Transliteration.ignoreKana to use a constructor,
but
forgot to implement that, or accidentally broke that service
implementation.)
So the com.sun.star.i18n.Transliteration.ignoreKana service implementation
has
not been instantiatable ever since 2014. But it appears that nobody missed
it
much, so maybe it had already been a mistake to add it (alongside the
com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation) in
2002.
So just remove it completely for good now.
Change-Id: Ieda888038a70f4123a0c5f9f4e3306491f32ed64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150068
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/i18npool/util/i18npool.component b/i18npool/util/i18npool.component
index b540f2bd98e2..725bf2387d0a 100644
--- a/i18npool/util/i18npool.component
+++ b/i18npool/util/i18npool.component
@@ -513,9 +513,6 @@
<implementation
name="com.sun.star.i18n.Transliteration.ignoreIterationMark_ja_JP">
<service name="com.sun.star.i18n.Transliteration.l10n"/>
</implementation>
- <implementation name="com.sun.star.i18n.Transliteration.ignoreKana">
- <service name="com.sun.star.i18n.Transliteration.l10n"/>
- </implementation>
<implementation
name="com.sun.star.i18n.Transliteration.ignoreKiKuFollowedBySa_ja_JP">
<service name="com.sun.star.i18n.Transliteration.l10n"/>
</implementation>
