cui/uiconfig/ui/hyphenate.ui |  123 +++++++++++++++++++++----------------------
 1 file changed, 62 insertions(+), 61 deletions(-)

New commits:
commit d7f78d469870717cfc356ce12413031b9d86079b
Author:     Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Thu Mar 23 11:23:06 2023 +0100
Commit:     Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Thu Mar 23 19:54:59 2023 +0000

    tdf#135769 a11y: Set a11y name and tooltip for buttons in hyphenation dialog
    
    Set accessible name and tooltip "Left" and "Right" for the
    left and right arrow buttons, as suggested in tdf#135769 comment 6.
    
    Change-Id: I233d7f9028b2336130475ce50a4161df0629a835
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149355
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>

diff --git a/cui/uiconfig/ui/hyphenate.ui b/cui/uiconfig/ui/hyphenate.ui
index 89ed9d1b2fc8..1a8814e375eb 100644
--- a/cui/uiconfig/ui/hyphenate.ui
+++ b/cui/uiconfig/ui/hyphenate.ui
@@ -208,11 +208,13 @@
                     <property name="visible">True</property>
                     <property name="can-focus">True</property>
                     <property name="receives-default">True</property>
+                    <property name="tooltip-text" 
context="hyphenate|tooltip|left" translatable="yes">Left</property>
                     <property name="halign">end</property>
                     <property name="image">image1</property>
                     <property name="always-show-image">True</property>
                     <child internal-child="accessible">
                       <object class="AtkObject" id="left-atkobject">
+                        <property name="AtkObject::accessible-name" 
translatable="yes" context="hyphenate|button_name|left">Left</property>
                         <property name="AtkObject::accessible-description" 
translatable="yes" context="hyphenate|extended_tip|left">Set the position of 
the hyphen. This option is only available if more than one hyphenation 
suggestion is displayed.</property>
                       </object>
                     </child>
@@ -227,11 +229,13 @@
                     <property name="visible">True</property>
                     <property name="can-focus">True</property>
                     <property name="receives-default">True</property>
+                    <property name="tooltip-text" 
context="hyphenate|tooltip|right" translatable="yes">Right</property>
                     <property name="halign">start</property>
                     <property name="image">image2</property>
                     <property name="always-show-image">True</property>
                     <child internal-child="accessible">
                       <object class="AtkObject" id="right-atkobject">
+                        <property name="AtkObject::accessible-name" 
context="hyphenate|button_name|right" translatable="yes">Right</property>
                         <property name="AtkObject::accessible-description" 
translatable="yes" context="hyphenate|extended_tip|right">Set the position of 
the hyphen. This option is only available if more than one hyphenation 
suggestion is displayed.</property>
                       </object>
                     </child>
commit db863e0aabfb9008bf7ca226e7da7c186d89e5ea
Author:     Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Thu Mar 23 11:10:12 2023 +0100
Commit:     Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Thu Mar 23 19:54:50 2023 +0000

    Resave cui/uiconfig/ui/hyphenate.ui with glade 3.40.0
    
    .. before doing any changes for tdf#135769
    
    Change-Id: If9ae28a979c4d4c12120711b90a9361b2e90b6c5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149421
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>

diff --git a/cui/uiconfig/ui/hyphenate.ui b/cui/uiconfig/ui/hyphenate.ui
index 386e5a98d2f7..89ed9d1b2fc8 100644
--- a/cui/uiconfig/ui/hyphenate.ui
+++ b/cui/uiconfig/ui/hyphenate.ui
@@ -1,41 +1,41 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.36.0 -->
+<!-- Generated with glade 3.40.0 -->
 <interface domain="cui">
   <requires lib="gtk+" version="3.20"/>
   <object class="GtkImage" id="image1">
     <property name="visible">True</property>
-    <property name="can_focus">False</property>
+    <property name="can-focus">False</property>
     <property name="icon-name">go-previous</property>
   </object>
   <object class="GtkImage" id="image2">
     <property name="visible">True</property>
-    <property name="can_focus">False</property>
+    <property name="can-focus">False</property>
     <property name="icon-name">go-next</property>
   </object>
   <object class="GtkDialog" id="HyphenateDialog">
-    <property name="can_focus">False</property>
-    <property name="border_width">6</property>
+    <property name="can-focus">False</property>
+    <property name="border-width">6</property>
     <property name="title" translatable="yes" 
context="hyphenate|HyphenateDialog">Hyphenation</property>
     <property name="resizable">False</property>
     <property name="modal">True</property>
-    <property name="default_width">0</property>
-    <property name="default_height">0</property>
-    <property name="type_hint">dialog</property>
+    <property name="default-width">0</property>
+    <property name="default-height">0</property>
+    <property name="type-hint">dialog</property>
     <child internal-child="vbox">
       <object class="GtkBox" id="dialog-vbox1">
-        <property name="can_focus">False</property>
+        <property name="can-focus">False</property>
         <property name="orientation">vertical</property>
         <property name="spacing">12</property>
         <child internal-child="action_area">
           <object class="GtkButtonBox" id="dialog-action_area1">
-            <property name="can_focus">False</property>
-            <property name="layout_style">end</property>
+            <property name="can-focus">False</property>
+            <property name="layout-style">end</property>
             <child>
               <object class="GtkButton" id="help">
                 <property name="label" translatable="yes" 
context="stock">_Help</property>
                 <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="receives_default">True</property>
+                <property name="can-focus">True</property>
+                <property name="receives-default">True</property>
                 <property name="use-underline">True</property>
               </object>
               <packing>
@@ -49,8 +49,8 @@
               <object class="GtkButton" id="hyphall">
                 <property name="label" translatable="yes" 
context="hyphenate|hyphall">Hyphenate All</property>
                 <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="receives_default">True</property>
+                <property name="can-focus">True</property>
+                <property name="receives-default">True</property>
               </object>
               <packing>
                 <property name="expand">False</property>
@@ -62,8 +62,8 @@
               <object class="GtkButton" id="close">
                 <property name="label" translatable="yes" 
context="stock">_Close</property>
                 <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="receives_default">True</property>
+                <property name="can-focus">True</property>
+                <property name="receives-default">True</property>
                 <property name="use-underline">True</property>
               </object>
               <packing>
@@ -76,34 +76,34 @@
           <packing>
             <property name="expand">False</property>
             <property name="fill">True</property>
-            <property name="pack_type">end</property>
+            <property name="pack-type">end</property>
             <property name="position">0</property>
           </packing>
         </child>
         <child>
-          <!-- n-columns=1 n-rows=1 -->
+          <!-- n-columns=3 n-rows=2 -->
           <object class="GtkGrid" id="grid1">
             <property name="visible">True</property>
-            <property name="can_focus">False</property>
+            <property name="can-focus">False</property>
             <property name="valign">start</property>
             <property name="hexpand">True</property>
-            <property name="row_spacing">6</property>
-            <property name="column_spacing">6</property>
+            <property name="row-spacing">6</property>
+            <property name="column-spacing">6</property>
             <child>
               <object class="GtkButtonBox" id="buttonbox1">
                 <property name="visible">True</property>
-                <property name="can_focus">False</property>
+                <property name="can-focus">False</property>
                 <property name="orientation">vertical</property>
                 <property name="spacing">6</property>
-                <property name="layout_style">start</property>
+                <property name="layout-style">start</property>
                 <child>
                   <object class="GtkButton" id="ok">
                     <property name="label" translatable="yes" 
context="hyphenate|ok">Hyphenate</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="can_default">True</property>
-                    <property name="has_default">True</property>
-                    <property name="receives_default">True</property>
+                    <property name="can-focus">True</property>
+                    <property name="can-default">True</property>
+                    <property name="has-default">True</property>
+                    <property name="receives-default">True</property>
                     <child internal-child="accessible">
                       <object class="AtkObject" id="ok-atkobject">
                         <property name="AtkObject::accessible-description" 
translatable="yes" context="hyphenate|extended_tip|ok">Inserts the hyphen at 
the indicated position.</property>
@@ -120,8 +120,8 @@
                   <object class="GtkButton" id="continue">
                     <property name="label" translatable="yes" 
context="hyphenate|continue">Skip</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="receives_default">True</property>
+                    <property name="can-focus">True</property>
+                    <property name="receives-default">True</property>
                     <child internal-child="accessible">
                       <object class="AtkObject" id="continue-atkobject">
                         <property name="AtkObject::accessible-description" 
translatable="yes" context="hyphenate|extended_tip|continue">Ignores the 
hyphenation suggestion and finds the next word to hyphenate.</property>
@@ -138,8 +138,8 @@
                   <object class="GtkButton" id="delete">
                     <property name="label" translatable="yes" 
context="stock">_Remove</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="receives_default">True</property>
+                    <property name="can-focus">True</property>
+                    <property name="receives-default">True</property>
                     <property name="use-underline">True</property>
                     <child internal-child="accessible">
                       <object class="AtkObject" id="delete-atkobject">
@@ -155,41 +155,41 @@
                 </child>
               </object>
               <packing>
-                <property name="left_attach">2</property>
-                <property name="top_attach">1</property>
+                <property name="left-attach">2</property>
+                <property name="top-attach">1</property>
               </packing>
             </child>
             <child>
               <object class="GtkLabel" id="label1">
                 <property name="visible">True</property>
-                <property name="can_focus">False</property>
+                <property name="can-focus">False</property>
                 <property name="label" translatable="yes" 
context="hyphenate|label1">Word:</property>
-                <property name="use_underline">True</property>
-                <property name="mnemonic_widget">worded</property>
+                <property name="use-underline">True</property>
+                <property name="mnemonic-widget">worded</property>
                 <property name="xalign">0</property>
               </object>
               <packing>
-                <property name="left_attach">0</property>
-                <property name="top_attach">0</property>
+                <property name="left-attach">0</property>
+                <property name="top-attach">0</property>
                 <property name="width">2</property>
               </packing>
             </child>
             <child>
-              <!-- n-columns=1 n-rows=1 -->
+              <!-- n-columns=2 n-rows=2 -->
               <object class="GtkGrid" id="grid2">
                 <property name="visible">True</property>
-                <property name="can_focus">False</property>
+                <property name="can-focus">False</property>
                 <property name="valign">start</property>
-                <property name="row_spacing">6</property>
-                <property name="column_spacing">12</property>
+                <property name="row-spacing">6</property>
+                <property name="column-spacing">12</property>
                 <child>
                   <object class="GtkEntry" id="worded">
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
+                    <property name="can-focus">True</property>
                     <property name="hexpand">True</property>
                     <property name="editable">False</property>
-                    <property name="activates_default">True</property>
-                    <property name="width_chars">32</property>
+                    <property name="activates-default">True</property>
+                    <property name="width-chars">32</property>
                     <property name="truncate-multiline">True</property>
                     <child internal-child="accessible">
                       <object class="AtkObject" id="worded-atkobject">
@@ -198,16 +198,16 @@
                     </child>
                   </object>
                   <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">0</property>
+                    <property name="left-attach">0</property>
+                    <property name="top-attach">0</property>
                     <property name="width">2</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkButton" id="left">
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="receives_default">True</property>
+                    <property name="can-focus">True</property>
+                    <property name="receives-default">True</property>
                     <property name="halign">end</property>
                     <property name="image">image1</property>
                     <property name="always-show-image">True</property>
@@ -218,15 +218,15 @@
                     </child>
                   </object>
                   <packing>
-                    <property name="left_attach">0</property>
-                    <property name="top_attach">1</property>
+                    <property name="left-attach">0</property>
+                    <property name="top-attach">1</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkButton" id="right">
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="receives_default">True</property>
+                    <property name="can-focus">True</property>
+                    <property name="receives-default">True</property>
                     <property name="halign">start</property>
                     <property name="image">image2</property>
                     <property name="always-show-image">True</property>
@@ -237,14 +237,14 @@
                     </child>
                   </object>
                   <packing>
-                    <property name="left_attach">1</property>
-                    <property name="top_attach">1</property>
+                    <property name="left-attach">1</property>
+                    <property name="top-attach">1</property>
                   </packing>
                 </child>
               </object>
               <packing>
-                <property name="left_attach">0</property>
-                <property name="top_attach">1</property>
+                <property name="left-attach">0</property>
+                <property name="top-attach">1</property>
                 <property name="width">2</property>
               </packing>
             </child>
@@ -265,9 +265,6 @@
       <action-widget response="101">hyphall</action-widget>
       <action-widget response="-7">close</action-widget>
     </action-widgets>
-    <child type="titlebar">
-      <placeholder/>
-    </child>
     <child internal-child="accessible">
       <object class="AtkObject" id="HyphenateDialog-atkobject">
         <property name="AtkObject::accessible-description" translatable="yes" 
context="hyphenate|extended_tip|HyphenateDialog">Inserts hyphens in words that 
are too long to fit at the end of a line.</property>

Reply via email to