basegfx/source/polygon/b2dpolygontools.cxx | 1 -
basegfx/source/polygon/b3dpolygontools.cxx | 1 -
sax/source/fastparser/fastparser.cxx | 2 +-
ucb/source/cacher/contentresultsetwrapper.cxx | 3 ---
vcl/source/filter/ipict/ipict.cxx | 2 +-
vcl/source/outdev/bitmapex.cxx | 2 --
vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx | 2 +-
7 files changed, 3 insertions(+), 10 deletions(-)
New commits:
commit 363512d39ba1543b7e91af1d59dadb5378da7649
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Mon Mar 6 15:09:25 2023 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Mar 6 16:48:15 2023 +0000
clang-tidy dead-store
Change-Id: I842114880c43dfcc342b6255b7d17befb905bccb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148345
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/basegfx/source/polygon/b2dpolygontools.cxx
b/basegfx/source/polygon/b2dpolygontools.cxx
index 03f5299ca505..900ab735a1e0 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -1255,7 +1255,6 @@ namespace basegfx::utils
// to enlarge these as needed
const double fFactor(fCandidateLength / fAllowedLength);
std::for_each(aDotDashArray.begin(), aDotDashArray.end(),
[&fFactor](double &f){ f *= fFactor; });
- fDotDashLength *= fFactor;
}
// prepare current edge's start
diff --git a/basegfx/source/polygon/b3dpolygontools.cxx
b/basegfx/source/polygon/b3dpolygontools.cxx
index a1f65bef2f48..3b3779d7460a 100644
--- a/basegfx/source/polygon/b3dpolygontools.cxx
+++ b/basegfx/source/polygon/b3dpolygontools.cxx
@@ -219,7 +219,6 @@ namespace basegfx::utils
// to enlarge these as needed
const double fFactor(fCandidateLength / fAllowedLength);
std::for_each(aDotDashArray.begin(), aDotDashArray.end(),
[&fFactor](double &f){ f *= fFactor; });
- fDotDashLength *= fFactor;
}
// prepare current edge's start
diff --git a/sax/source/fastparser/fastparser.cxx
b/sax/source/fastparser/fastparser.cxx
index aae3c1162d47..06e2fb1e3e92 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -1565,7 +1565,7 @@ static void NormalizeURI( OUString& rName )
// try OASIS + W3 URI normalization
bool bSuccess = NormalizeOasisURN( rName );
if( ! bSuccess )
- bSuccess = NormalizeW3URI( rName );
+ NormalizeW3URI( rName );
}
constexpr OUStringLiteral XML_URI_W3_PREFIX(u"http://www.w3.org/";);
diff --git a/ucb/source/cacher/contentresultsetwrapper.cxx
b/ucb/source/cacher/contentresultsetwrapper.cxx
index f6e7c0058a65..72388222f12d 100644
--- a/ucb/source/cacher/contentresultsetwrapper.cxx
+++ b/ucb/source/cacher/contentresultsetwrapper.cxx
@@ -275,10 +275,7 @@ void SAL_CALL ContentResultSetWrapper::dispose()
}
if (isCleared)
- {
aGuard.lock();
- isCleared = false;
- }
if( m_aDisposeEventListeners.getLength(aGuard) )
{
EventObject aEvt;
diff --git a/vcl/source/filter/ipict/ipict.cxx
b/vcl/source/filter/ipict/ipict.cxx
index fcdef08e3592..2d9be6f8cd9c 100644
--- a/vcl/source/filter/ipict/ipict.cxx
+++ b/vcl/source/filter/ipict/ipict.cxx
@@ -783,7 +783,7 @@ sal_uInt64 PictReader::ReadPixMapEtc( BitmapEx &rBitmap,
bool bBaseAddr, bool bC
else
{
nRowBytes &= 0x3fff;
- nPixelSize = nCmpCount = nCmpSize = 1;
+ nPixelSize = nCmpCount = 1;
nDataSize += 10;
aPalette.resize(2);
aPalette[0] = Color(0xff, 0xff, 0xff);
diff --git a/vcl/source/outdev/bitmapex.cxx b/vcl/source/outdev/bitmapex.cxx
index 57851f943f51..9935a18bdee6 100644
--- a/vcl/source/outdev/bitmapex.cxx
+++ b/vcl/source/outdev/bitmapex.cxx
@@ -522,8 +522,6 @@ void OutputDevice::DrawTransformedBitmapEx(
aAlpha.BlendWith( bitmapEx.GetAlphaMask());
bitmapEx = BitmapEx( bitmapEx.GetBitmap(), aAlpha );
}
- if(rtl::math::approxEqual( fAlpha, 1.0 ))
- fAlpha = 1.0; // avoid the need for approxEqual in backends
// If the backend's implementation is known to not need any optimizations
here, pass to it directly.
// With most backends it's more performant to try to simplify to
DrawBitmapEx() first.
diff --git a/vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx
b/vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx
index 9afb55f0eb21..36278074c446 100644
--- a/vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx
@@ -1677,7 +1677,7 @@ void SalGtkFilePicker::impl_initialize(GtkWidget*
pParentWidget, sal_Int16 templ
GtkFileChooserAction eAction = GTK_FILE_CHOOSER_ACTION_OPEN;
OString sOpen = getOpenText();
OString sSave = getSaveText();
- const gchar *first_button_text = sOpen.getStr();
+ const gchar *first_button_text;
SolarMutexGuard g;
