[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/data/xml/tdf153444.xml      |   29 +++++++++++++++++++++++++++++
 sc/qa/unit/subsequent_filters_test.cxx |   20 ++++++++++++++++++++
 2 files changed, 49 insertions(+)

New commits:
commit 3914491f0717a1842bf9a29a399bb5ef0c2f2db4
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Wed Feb 15 09:57:44 2023 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Wed Feb 15 14:10:48 2023 +0000

    tdf#153444: sc_subsequent_filters_test: Add unittest
    
    Change-Id: I9b58c396f18764e1821f7d5063bba5559bfbf021
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147043
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/sc/qa/unit/data/xml/tdf153444.xml 
b/sc/qa/unit/data/xml/tdf153444.xml
new file mode 100644
index 000000000000..7ff6d5c7c121
--- /dev/null
+++ b/sc/qa/unit/data/xml/tdf153444.xml
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="ISO-8859-15"?>
+<?mso-application progid="Excel.Sheet"?>
+<Workbook xmlns="urn:schemas-microsoft-com:office:spreadsheet"
+ xmlns:o="urn:schemas-microsoft-com:office:office"
+ xmlns:x="urn:schemas-microsoft-com:office:excel"
+ xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet"
+ xmlns:html="http://www.w3.org/TR/REC-html40";>
+ <Worksheet ss:Name="iso-8859-12">
+  <Table ss:ExpandedColumnCount="6" ss:ExpandedRowCount="0000004036" 
x:FullColumns="1"
+   x:FullRows="1" ss:DefaultColumnWidth="60">
+   <Row>
+    <Cell><Data ss:Type="String">time, sec</Data></Cell>
+    <Cell><Data ss:Type="String">Body_Right_Z, g</Data></Cell>
+    <Cell><Data ss:Type="String">Body_Left_Z, g</Data></Cell>
+    <Cell><Data ss:Type="String">���, �m/m</Data></Cell>
+    <Cell><Data ss:Type="String">���, �m/m</Data></Cell>
+    <Cell><Data ss:Type="String">�, �m/m</Data></Cell>
+   </Row>
+   <Row>
+    <Cell><Data ss:Type="Number">+0.0000000e+00</Data></Cell>
+    <Cell><Data ss:Type="Number">-2.7905207e-04</Data></Cell>
+    <Cell><Data ss:Type="Number">-1.6600988e-04</Data></Cell>
+    <Cell><Data ss:Type="Number">+0.0000000e+00</Data></Cell>
+    <Cell><Data ss:Type="Number">+0.0000000e+00</Data></Cell>
+    <Cell><Data ss:Type="Number">+0.0000000e+00</Data></Cell>
+   </Row>
+  </Table>
+ </Worksheet>
+</Workbook>
diff --git a/sc/qa/unit/subsequent_filters_test.cxx 
b/sc/qa/unit/subsequent_filters_test.cxx
index 45598beae411..10cf129c0412 100644
--- a/sc/qa/unit/subsequent_filters_test.cxx
+++ b/sc/qa/unit/subsequent_filters_test.cxx
@@ -187,6 +187,7 @@ public:
     void testCellAnchoredHiddenShapesXLSX();
 
     void testFormulaDependency();
+    void testTdf153444();
     void testTdf151046();
 
     void testRowHeightODS();
@@ -307,6 +308,7 @@ public:
 
     CPPUNIT_TEST(testRowHeightODS);
     CPPUNIT_TEST(testFormulaDependency);
+    CPPUNIT_TEST(testTdf153444);
     CPPUNIT_TEST(testTdf151046);
     CPPUNIT_TEST(testRichTextContentODS);
 
@@ -3115,6 +3117,24 @@ void ScFiltersTest::testFormulaDependency()
     // CPPUNIT_ASSERT_EQUAL(pDoc->GetString(0,4,0), rDoc.GetString(0,5,0));
 }
 
+void ScFiltersTest::testTdf153444()
+{
+    createScDoc("xml/tdf153444.xml");
+
+    ScDocument* pDoc = getScDoc();
+
+    CPPUNIT_ASSERT_EQUAL(OUString(u"time, sec"), pDoc->GetString(0, 0, 0));
+    CPPUNIT_ASSERT_EQUAL(OUString(u"Body_Right_Z, g"), pDoc->GetString(1, 0, 
0));
+    CPPUNIT_ASSERT_EQUAL(OUString(u"Body_Left_Z, g"), pDoc->GetString(2, 0, 
0));
+
+    // Without the fix in place, this test would have failed with
+    // - Expected: ÄÖÜ, µm/m
+    // - Actual  : ���, �m/m
+    CPPUNIT_ASSERT_EQUAL(OUString(u"ÄÖÜ, µm/m"), pDoc->GetString(3, 0, 0));
+    CPPUNIT_ASSERT_EQUAL(OUString(u"äöü, µm/m"), pDoc->GetString(4, 0, 0));
+    CPPUNIT_ASSERT_EQUAL(OUString(u"ß, µm/m"), pDoc->GetString(5, 0, 0));
+}
+
 void ScFiltersTest::testTdf151046()
 {
     createScDoc("ods/tdf151046.ods");