[Libreoffice-commits] core.git: sw/source

[Mike Kaganski (via logerrit)]

 sw/source/core/doc/textboxhelper.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 87f03db116f7f36c929f5cdbfe38f19ae57d34ac
Author:     Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Tue Jan 31 11:57:38 2023 +0300
Commit:     Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Tue Jan 31 13:52:53 2023 +0000

    tdf#153289: remove problematic assertion
    
    It is unclear what it should guarantee; but at least when ungrouping,
    SwDoc::UnGroupSelection copy-constructs a shared pointer (increasing
    the refcount), then a copy-constructed argument passed to
    lcl_CollectTextBoxesForSubGroupObj increases it once again, and then
    the assertion expectedly fails.
    
    Change-Id: I0cb5f303c67b2dc67d5583a9eb03fe405af3573d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146377
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>

diff --git a/sw/source/core/doc/textboxhelper.cxx 
b/sw/source/core/doc/textboxhelper.cxx
index f253502e56a6..98fc0512acfd 100644
--- a/sw/source/core/doc/textboxhelper.cxx
+++ b/sw/source/core/doc/textboxhelper.cxx
@@ -1795,7 +1795,6 @@ SwFrameFormat* SwTextBoxNode::GetTextBox(const SdrObject* 
pDrawObject) const
         if (size_t(pTextBoxes.use_count()) != pTextBoxes->GetTextBoxCount() + 
size_t(1))
         {
             SAL_WARN("sw.core", "SwTextBoxNode::GetTextBox(): RefCount and 
TexBox count mismatch!");
-            assert(false);
         }
     }