[Libreoffice-commits] core.git: sal/osl

[Stephan Bergmann (via logerrit)]

 sal/osl/unx/file_misc.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b74d50003145f3805e3316a51c8be0222e680152
Author:     Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Thu Nov 10 18:59:54 2022 +0100
Commit:     Stephan Bergmann <sberg...@redhat.com>
CommitDate: Fri Nov 11 15:40:45 2022 +0100

    Drop useless std::move of const object
    
    ...introduced with d8b60f77f389a248f98aa45592e6e1045baafbe1 
"rtl_String->OString
    in DirectoryItem_Impl".
    
    (I came across this code with an upcoming loplugin:constmove that flags
    suspicious uses of std::move involving const-qualified types.)
    
    Change-Id: I3df2e6fb9dbf97adba6fbeda51d24cf025f5b207
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142565
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/sal/osl/unx/file_misc.cxx b/sal/osl/unx/file_misc.cxx
index c411b78cc260..01842dc73154 100644
--- a/sal/osl/unx/file_misc.cxx
+++ b/sal/osl/unx/file_misc.cxx
@@ -330,9 +330,9 @@ oslFileError SAL_CALL osl_getNextDirectoryItem(oslDirectory 
pDirectory,
         pImpl = nullptr;
     }
 #ifdef _DIRENT_HAVE_D_TYPE
-    pImpl = new DirectoryItem_Impl(std::move(strFilePath), pEntry->d_type);
+    pImpl = new DirectoryItem_Impl(strFilePath, pEntry->d_type);
 #else
-    pImpl = new DirectoryItem_Impl(std::move(strFilePath));
+    pImpl = new DirectoryItem_Impl(strFilePath);
 #endif /* _DIRENT_HAVE_D_TYPE */
     *pItem = pImpl;