svx/source/sdr/contact/viewobjectcontact.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 15abaa8a35ddca43cebf884ec728350f9ae8fb08
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Thu Nov 10 18:52:45 2022 +0100
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Fri Nov 11 14:10:01 2022 +0100
Drop counterproductive const'ness of a member function
...introduced in c8d2fa176a15a7ae76d6a4b76aea5f108313c2ec "reduce copying in
drawinglayer", but thwarting the use of std::move on a data member.
(I came across this code with an upcoming loplugin:constmove that flags
suspicious uses of std::move involving const-qualified types.)
Change-Id: I9b32d8762b4cc57875343664642494c7098ffb4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142563
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/svx/source/sdr/contact/viewobjectcontact.cxx
b/svx/source/sdr/contact/viewobjectcontact.cxx
index 266b3151873f..9adc4e713b22 100644
--- a/svx/source/sdr/contact/viewobjectcontact.cxx
+++ b/svx/source/sdr/contact/viewobjectcontact.cxx
@@ -69,7 +69,7 @@ public:
// data access
const drawinglayer::primitive2d::Primitive2DContainer&
getPrimitive2DSequence() const { return maPrimitive2DSequence; }
- drawinglayer::primitive2d::Primitive2DContainer
extractPrimitive2DSequence() const { return std::move(maPrimitive2DSequence); }
+ drawinglayer::primitive2d::Primitive2DContainer
extractPrimitive2DSequence() { return std::move(maPrimitive2DSequence); }
};
AnimatedExtractingProcessor2D::AnimatedExtractingProcessor2D(
