[Libreoffice-commits] core.git: sw/source

[Stephan Bergmann (via logerrit)]

 sw/source/core/crsr/bookmark.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8e108264fee9e945d7f9fc007d11dfb4b180e775
Author:     Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Tue Oct 25 08:15:42 2022 +0200
Commit:     Stephan Bergmann <sberg...@redhat.com>
CommitDate: Tue Oct 25 09:25:37 2022 +0200

    Add missing semicolon
    
    ...in code recently introduced in 0bf8a781ffec13b4fbcb96a2e9349b423a92cb1d
    "related tdf#151548 sw: KEY_DOWN access to FieldmarkWithDropDownButton", 
which
    at least GCC 12 and recent GCC 13 trunk in an --enable-dbgutil
    --enable-optimized --enable-werror build diagnosed as
    
    > sw/source/core/crsr/bookmark.cxx: In member function ‘void 
sw::mark::FieldmarkWithDropDownButton::LaunchPopup()’:
    > sw/source/core/crsr/bookmark.cxx:669:30: error: ‘this’ pointer is null 
[-Werror=nonnull]
    >   669 |         m_pButton->Invalidate();
    >       |         ~~~~~~~~~~~~~~~~~~~~~^~
    > cc1plus: all warnings being treated as errors
    
    Change-Id: I1e6d7e7e0244259674d41edff4c07a2de2b74bdc
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141791
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/sw/source/core/crsr/bookmark.cxx b/sw/source/core/crsr/bookmark.cxx
index cebe18788537..6801dd64db14 100644
--- a/sw/source/core/crsr/bookmark.cxx
+++ b/sw/source/core/crsr/bookmark.cxx
@@ -664,7 +664,7 @@ namespace sw::mark
     void FieldmarkWithDropDownButton::LaunchPopup()
     {
         if (!m_pButton)
-            return
+            return;
 
         m_pButton->Invalidate();
         m_pButton->LaunchPopup();