[Libreoffice-commits] core.git: sfx2/source

[Khaled Hosny (via logerrit)]

 sfx2/source/appl/shutdowniconaqua.mm |   20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)

New commits:
commit b2808ebfeb8654d349f6324fa2bc0f6e97af4e33
Author:     Khaled Hosny <kha...@aliftype.com>
AuthorDate: Thu Sep 29 10:28:53 2022 +0200
Commit:     خالد حسني <kha...@aliftype.com>
CommitDate: Thu Sep 29 11:35:17 2022 +0200

    tdf#55922: Remove redundant macOS dock icon menu
    
    The File → Recent Documents is redundant since macOS shows recent
    document on the main dock icon menu.
    
    Change-Id: I644745309fb06f340fb871f3a5dba620c279e718
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140721
    Tested-by: Jenkins
    Reviewed-by: خالد حسني <kha...@aliftype.com>

diff --git a/sfx2/source/appl/shutdowniconaqua.mm 
b/sfx2/source/appl/shutdowniconaqua.mm
index 1a692f7ed164..f5d9e2d5db8d 100644
--- a/sfx2/source/appl/shutdowniconaqua.mm
+++ b/sfx2/source/appl/shutdowniconaqua.mm
@@ -327,7 +327,7 @@ static void appendMenuItem( NSMenu* i_pMenu, NSMenu* 
i_pDockMenu, const OUString
     }
 }
 
-static void appendRecentMenu( NSMenu* i_pMenu, NSMenu* i_pDockMenu, const 
OUString& i_rTitle )
+static void appendRecentMenu( NSMenu* i_pMenu, const OUString& i_rTitle )
 {
     if( ! pRecentDelegate )
         pRecentDelegate = [[RecentMenuDelegate alloc] init];
@@ -343,22 +343,6 @@ static void appendRecentMenu( NSMenu* i_pMenu, NSMenu* 
i_pDockMenu, const OUStri
 
     [pRecentMenu setAutoenablesItems: NO];
     [pItem setSubmenu: pRecentMenu];
-
-    if( i_pDockMenu )
-    {
-        // create a similar entry in the dock menu
-        pItem = [i_pDockMenu addItemWithTitle: getAutoreleasedString( i_rTitle 
)
-                             action: @selector(executeMenuItem:)
-                             keyEquivalent: @""
-                        ];
-        [pItem setEnabled: YES];
-        pRecentMenu = [[NSMenu alloc] initWithTitle: getAutoreleasedString( 
i_rTitle ) ];
-
-        [pRecentMenu setDelegate: pRecentDelegate];
-
-        [pRecentMenu setAutoenablesItems: NO];
-        [pItem setSubmenu: pRecentMenu];
-    }
 }
 
 
@@ -451,7 +435,7 @@ void aqua_init_systray()
             // insert the remaining menu entries
 
             // add recent menu
-            appendRecentMenu( pMenu, pDockMenu, 
SfxResId(STR_QUICKSTART_RECENTDOC) );
+            appendRecentMenu( pMenu, SfxResId(STR_QUICKSTART_RECENTDOC) );
 
             OUString aTitle( SfxResId(STR_QUICKSTART_FROMTEMPLATE) );
             OUString aKeyEquiv( getShortCut( aTitle ) );