[Libreoffice-commits] core.git: basctl/source

[Caolán McNamara (via logerrit)]

 basctl/source/basicide/moduldlg.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 67224d9ea094ac3db7bf9f8dd77bc1245ca5eb85
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Thu Aug 18 09:12:55 2022 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Thu Aug 18 11:38:36 2022 +0200

    cid#1500394 Explicit null dereferenced
    
    Change-Id: Ie97b047b793c0d9546a17f9e9f1d20cbeed62626
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138469
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/basctl/source/basicide/moduldlg.cxx 
b/basctl/source/basicide/moduldlg.cxx
index dc46c7db0677..a6ce17179f50 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -397,7 +397,7 @@ private:
         // get source shell, library name and module/dialog name
         std::unique_ptr<weld::TreeIter> xSelected(m_rTreeView.make_iterator());
         if (!m_rTreeView.get_selected(xSelected.get()))
-            xSelected.reset();
+            return;
         EntryDescriptor aSourceDesc = 
m_rTreeView.GetEntryDescriptor(xSelected.get());
         const ScriptDocument& rSourceDoc( aSourceDesc.GetDocument() );
         const OUString& aSourceLibName( aSourceDesc.GetLibName() );