[Libreoffice-commits] core.git: test/source

[Colomban Wendling (via logerrit)]

 test/source/a11y/AccessibilityTools.cxx |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

New commits:
commit d6ce547a1a24379bf1783387e22cbf8d39866757
Author:     Colomban Wendling <cwendl...@hypra.fr>
AuthorDate: Thu Jul 21 17:43:34 2022 +0200
Commit:     Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Wed Jul 27 17:35:03 2022 +0200

    Better report unknown constant names by including their values
    
    Change-Id: Id93dedf39ad0e2d1968e80878dd1a1bb07d94b61
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137336
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>

diff --git a/test/source/a11y/AccessibilityTools.cxx 
b/test/source/a11y/AccessibilityTools.cxx
index 266e536dd3ba..44b168b54a94 100644
--- a/test/source/a11y/AccessibilityTools.cxx
+++ b/test/source/a11y/AccessibilityTools.cxx
@@ -112,6 +112,11 @@ bool AccessibilityTools::equals(const 
uno::Reference<accessibility::XAccessibleC
     return equals(xctx1->getAccessibleParent(), xctx2->getAccessibleParent());
 }
 
+static OUString unknownName(const sal_Int64 value)
+{
+    return "unknown (" + OUString::number(value) + ")";
+}
+
 OUString AccessibilityTools::getRoleName(const sal_Int16 role)
 {
     switch (role)
@@ -291,7 +296,7 @@ OUString AccessibilityTools::getRoleName(const sal_Int16 
role)
         case accessibility::AccessibleRole::WINDOW:
             return "WINDOW";
     };
-    return "unknown";
+    return unknownName(role);
 }
 
 OUString AccessibilityTools::debugAccessibleStateSet(const sal_Int64 
nCombinedState)
@@ -411,6 +416,9 @@ OUString AccessibilityTools::debugAccessibleStateSet(const 
sal_Int64 nCombinedSt
             case accessibility::AccessibleStateType::VISIBLE:
                 name = "VISIBLE";
                 break;
+            default:
+                name = unknownName(state);
+                break;
         }
         if (combinedName.getLength())
             combinedName += " | ";
@@ -509,7 +517,7 @@ OUString AccessibilityTools::getEventIdName(const sal_Int16 
event_id)
         case accessibility::AccessibleEventId::VISIBLE_DATA_CHANGED:
             return "VISIBLE_DATA_CHANGED";
     }
-    return "unknown";
+    return unknownName(event_id);
 }
 
 OUString AccessibilityTools::getRelationTypeName(const sal_Int16 rel_type)
@@ -539,7 +547,7 @@ OUString AccessibilityTools::getRelationTypeName(const 
sal_Int16 rel_type)
         case accessibility::AccessibleRelationType::SUB_WINDOW_OF:
             return "SUB_WINDOW_OF";
     }
-    return "unknown";
+    return unknownName(rel_type);
 }
 
 OUString AccessibilityTools::debugName(accessibility::XAccessibleContext* ctx)