include/vcl/metaact.hxx | 2 +-
vcl/inc/pdf/pdfwriter_impl.hxx | 2 +-
vcl/source/gdi/metaact.cxx | 4 ++--
vcl/source/gdi/pdfwriter_impl.cxx | 5 ++---
vcl/unx/generic/print/prtsetup.cxx | 5 ++---
vcl/unx/generic/print/prtsetup.hxx | 2 +-
6 files changed, 9 insertions(+), 11 deletions(-)
New commits:
commit 278e97ab0272e9c1975bd7780697067f0b91bd46
Author: Caolán McNamara <caol...@redhat.com>
AuthorDate: Mon Jul 18 09:13:21 2022 +0100
Commit: Caolán McNamara <caol...@redhat.com>
CommitDate: Mon Jul 18 20:19:15 2022 +0200
cid#1507357 Big parameter passed by value
and
cid#1507358 Big parameter passed by value
cid#1507359 Big parameter passed by value
Change-Id: I7adb0497e4e8b90683ee644790c4657b8ac75fef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caol...@redhat.com>
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index 1719fca6ff6d..37c3db3d9273 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -1096,7 +1096,7 @@ public:
virtual rtl::Reference<MetaAction> Clone() const override;
MetaWallpaperAction( const tools::Rectangle& rRect,
- Wallpaper aPaper );
+ const Wallpaper& rPaper );
virtual void Move( tools::Long nHorzMove, tools::Long nVertMove )
override;
virtual void Scale( double fScaleX, double fScaleY ) override;
diff --git a/vcl/inc/pdf/pdfwriter_impl.hxx b/vcl/inc/pdf/pdfwriter_impl.hxx
index b72e497446d6..228df387fb6d 100644
--- a/vcl/inc/pdf/pdfwriter_impl.hxx
+++ b/vcl/inc/pdf/pdfwriter_impl.hxx
@@ -1067,7 +1067,7 @@ i12626
void appendStrokingColor( const Color& rColor, OStringBuffer& rBuffer );
void appendNonStrokingColor( const Color& rColor, OStringBuffer& rBuffer );
public:
- PDFWriterImpl( PDFWriter::PDFWriterContext aContext, const
css::uno::Reference< css::beans::XMaterialHolder >&, PDFWriter& );
+ PDFWriterImpl( const PDFWriter::PDFWriterContext& rContext, const
css::uno::Reference< css::beans::XMaterialHolder >&, PDFWriter& );
~PDFWriterImpl() override;
void dispose() override;
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index f9d698b420e4..4d6705e39115 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -1289,10 +1289,10 @@ MetaWallpaperAction::~MetaWallpaperAction()
{}
MetaWallpaperAction::MetaWallpaperAction( const tools::Rectangle& rRect,
- Wallpaper aPaper ) :
+ const Wallpaper& rPaper ) :
MetaAction ( MetaActionType::WALLPAPER ),
maRect ( rRect ),
- maWallpaper (std::move( aPaper ))
+ maWallpaper ( rPaper )
{}
void MetaWallpaperAction::Execute( OutputDevice* pOut )
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 514b0506ac68..ae78eda251e5 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -59,7 +59,6 @@
#include <tools/urlobj.hxx>
#include <tools/zcodec.hxx>
#include <svl/cryptosign.hxx>
-#include <utility>
#include <vcl/bitmapex.hxx>
#include <vcl/canvastools.hxx>
#include <vcl/cvtgrf.hxx>
@@ -1192,7 +1191,7 @@ double PDFPage::getHeight() const
return fRet;
}
-PDFWriterImpl::PDFWriterImpl( PDFWriter::PDFWriterContext aContext,
+PDFWriterImpl::PDFWriterImpl( const PDFWriter::PDFWriterContext& rContext,
const css::uno::Reference<
css::beans::XMaterialHolder >& xEnc,
PDFWriter& i_rOuterFace)
: VirtualDevice(Application::GetDefaultDevice(),
DeviceFormat::DEFAULT, DeviceFormat::NONE, OUTDEV_PDF),
@@ -1209,7 +1208,7 @@ PDFWriterImpl::PDFWriterImpl( PDFWriter::PDFWriterContext
aContext,
m_nSignatureLastByteRangeNoOffset( 0 ),
m_nResourceDict( -1 ),
m_nFontDictObject( -1 ),
- m_aContext(std::move(aContext)),
+ m_aContext(rContext),
m_aFile(m_aContext.URL),
m_bOpen(false),
m_DocDigest(::comphelper::HashType::MD5),
diff --git a/vcl/unx/generic/print/prtsetup.cxx
b/vcl/unx/generic/print/prtsetup.cxx
index 0ff7366fab6c..56ee475e701e 100644
--- a/vcl/unx/generic/print/prtsetup.cxx
+++ b/vcl/unx/generic/print/prtsetup.cxx
@@ -22,7 +22,6 @@
#include <strings.hrc>
#include <officecfg/Office/Common.hxx>
-#include <utility>
using namespace psp;
@@ -68,9 +67,9 @@ void RTSDialog::insertAllPPDValues(weld::ComboBox& rBox,
const PPDParser* pParse
* RTSDialog
*/
-RTSDialog::RTSDialog(PrinterInfo aJobData, weld::Window* pParent)
+RTSDialog::RTSDialog(const PrinterInfo& rJobData, weld::Window* pParent)
: GenericDialogController(pParent, "vcl/ui/printerpropertiesdialog.ui",
"PrinterPropertiesDialog")
- , m_aJobData(std::move(aJobData))
+ , m_aJobData(rJobData)
, m_bDataModified(false)
, m_xTabControl(m_xBuilder->weld_notebook("tabcontrol"))
, m_xOKButton(m_xBuilder->weld_button("ok"))
diff --git a/vcl/unx/generic/print/prtsetup.hxx
b/vcl/unx/generic/print/prtsetup.hxx
index 4052bb50aa03..bcf86670d0b6 100644
--- a/vcl/unx/generic/print/prtsetup.hxx
+++ b/vcl/unx/generic/print/prtsetup.hxx
@@ -52,7 +52,7 @@ class RTSDialog : public weld::GenericDialogController
void insertAllPPDValues(weld::ComboBox&, const psp::PPDParser*, const
psp::PPDKey*);
public:
- RTSDialog(::psp::PrinterInfo aJobData, weld::Window* pParent);
+ RTSDialog(const ::psp::PrinterInfo& rJobData, weld::Window* pParent);
virtual ~RTSDialog() override;
const ::psp::PrinterInfo& getSetup() const { return m_aJobData; }
