[Libreoffice-commits] core.git: sfx2/source

[Noel Grandin (via logerrit)]

 sfx2/source/appl/childwin.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit bf29483599c67cebfe0c3e06d063d3ae233b28dc
Author:     Noel Grandin <noelgran...@gmail.com>
AuthorDate: Tue Jun 7 21:06:10 2022 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed Jun 8 08:40:26 2022 +0200

    tdf#81293 dialog “manage names” forgets size and column width settings
    
    I can't see any reason for this code to be this way. I can
    see that Jim has tried to make some dialogs retain window size and
    position. Surely all dialogs should be able to do this?
    Unfortunately, it has been this way since initial commit.
    
    Let us live dangerously and see what happens if we give
    power to ALL the dialogs.
    
       VIVA LA REVOLUTION!!!
    
    Change-Id: I44e389ba3cb46793365607d36a05474584ee6490
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135478
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/sfx2/source/appl/childwin.cxx b/sfx2/source/appl/childwin.cxx
index 75d72cae0e2b..1740459e7aea 100644
--- a/sfx2/source/appl/childwin.cxx
+++ b/sfx2/source/appl/childwin.cxx
@@ -233,13 +233,11 @@ std::unique_ptr<SfxChildWindow> 
SfxChildWindow::CreateChildWindow( sal_uInt16 nI
         pFact = pMod->GetChildWinFactoryById(nId);
         if ( pFact )
         {
-            SfxChildWinInfo& rFactInfo = pFact->aInfo;
             if ( rInfo.bVisible )
             {
                 if ( pBindings )
                     pBindings->ENTERREGISTRATIONS();
-                SfxChildWinInfo aInfo = (nId == SID_SEARCH_DLG || nId == 
SID_NAVIGATOR) ?
-                            rInfo : rFactInfo;
+                SfxChildWinInfo aInfo = rInfo;
                 Application::SetSystemWindowMode( 
SystemWindowFlags::NOAUTOMODE );
                 pChild = pFact->pCtor( pParent, nId, pBindings, &aInfo );
                 Application::SetSystemWindowMode( nOldMode );