[Libreoffice-commits] core.git: vcl/inc

[Mike Kaganski (via logerrit)]

 vcl/inc/impanmvw.hxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0c87c0b87a3bbc2c57b2dd65ba2dd0aeb2f0b0c3
Author:     Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Mon May 9 10:27:03 2022 +0300
Commit:     Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Mon May 9 11:57:06 2022 +0200

    Fix --disable-pch build: explicitly delete move constructor
    
    Without this, the implicitly created constructor is exported by MSVC
    for the DLLPUBLIC class, and requires that VirtualDevice is defined,
    resulting in this error in PCH-disabled builds:
    
      [build CXX] vcl/source/animate/Animation.cxx
      C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined 
type 'VirtualDevice'
      C:\lo\src\core\vcl\inc\impanmvw.hxx(29): note: see declaration of 
'VirtualDevice'
      C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class 
template member function 'rtl::Reference<reference_type>::~Reference(void)'
      with
      [
      reference_type=VirtualDevice
      ]
      C:\lo\src\core\include\vcl/vclptr.hxx(216): note: see reference to 
function template instantiation 
'rtl::Reference<reference_type>::~Reference(void)' being comp
      iled
      with
      [
      reference_type=VirtualDevice
      ]
      C:\lo\src\core\include\vcl/vclptr.hxx(64): note: see reference to class 
template instantiation 'rtl::Reference<reference_type>' being compiled
      with
      [
      reference_type=VirtualDevice
      ]
      C:\lo\src\core\include\vcl/outdev.hxx(202): note: see reference to class 
template instantiation 'VclPtr<VirtualDevice>' being compiled
      make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:337: 
C:/lo/src/build/workdir/CxxObject/vcl/source/animate/Animation.o] Error 2
    
    Change-Id: I78723ce7d00667595aff39bcab22169ff347098f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134036
    Tested-by: Mike Kaganski <mike.kagan...@collabora.com>
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>

diff --git a/vcl/inc/impanmvw.hxx b/vcl/inc/impanmvw.hxx
index be48421f5abd..5323afbccebc 100644
--- a/vcl/inc/impanmvw.hxx
+++ b/vcl/inc/impanmvw.hxx
@@ -72,6 +72,7 @@ public:
                     ImplAnimView( Animation* pParent, OutputDevice* pOut,
                                   const Point& rPt, const Size& rSz, sal_uLong 
nExtraData,
                                   OutputDevice* pFirstFrameOutDev = nullptr );
+                    ImplAnimView(ImplAnimView&&) = delete;
                     ~ImplAnimView();
 
     bool            matches(const OutputDevice* pOut, tools::Long nExtraData) 
const;