Hello Kendy, Stephan,

first: Stephan, I'm very sorry for breaking your tinderbox(es) for
days and not noticing it. (I just assumed my 2-byte change of a commit
was innocent enough. I'll do make check in the future as you advised.)

With some dumbluck and [1], I've managed to get it down to 1 failing test.

My approach so far was to just unconditionally add a sheet (in the
case of the XMLStylesExporter and XMLSettingsExporter I just made sure
these tests actually ran on Sheet 1 (=0), not Sheet 2 (=1)).
Since I guess my approach is less than optimal, do tell me if I need
to wrap stuff in try/catch or so. Or, if I should ask LibO how many
sheets there are before creating a new one. Or something else.

About the last failing test, sc_unoapi/ScModelObj, I am unsure where
it needs the second sheet, so I didn't add anything yet. Advice
appreciated.

Astron.

[1] 
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/FirstSteps/Example:_Working_with_a_Spreadsheet_Document

Attachment: 0001-Fix-up-unit-tests-that-assumed-two-or-more-sheets-pe.patch
Description: Binary data

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to