dbaccess/qa/extras/dialog-save.cxx       |    6 ------
 dbaccess/qa/extras/empty-stdlib-save.cxx |    6 ------
 dbaccess/qa/extras/nolib-save.cxx        |    6 ------
 3 files changed, 18 deletions(-)

New commits:
commit 7ac19fbce8a35f559eebb879cd0f232bfc95e703
Author:     Luboš Luňák <l.lu...@collabora.com>
AuthorDate: Sat Mar 5 10:16:10 2022 +0100
Commit:     Luboš Luňák <l.lu...@collabora.com>
CommitDate: Sat Mar 5 23:53:53 2022 +0100

    remove a workaround that appears to be no longer necessary
    
    Presumably whatever the locking problem was, it's got fixed
    meanwhile.
    
    Change-Id: I7bbd6299a501396f53ed2e8ccaf7d5893744512b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131047
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lu...@collabora.com>

diff --git a/dbaccess/qa/extras/dialog-save.cxx 
b/dbaccess/qa/extras/dialog-save.cxx
index ff4f612dc869..212127d48ea9 100644
--- a/dbaccess/qa/extras/dialog-save.cxx
+++ b/dbaccess/qa/extras/dialog-save.cxx
@@ -49,12 +49,6 @@ DialogSaveTest::DialogSaveTest()
 
 void DialogSaveTest::test()
 {
-    // UnoApiTest::setUp (via InitVCL) puts each test under a locked 
SolarMutex,
-    // but at least the below xDocCloseable->close call could lead to a 
deadlock
-    // then, and it looks like none of the code here requires the SolarMutex to
-    // be locked anyway:
-    SolarMutexReleaser rel;
-
     const OUString 
aFileName(m_directories.getURLFromWorkdir(u"CppunitTest/testDialogSave.odb"));
     {
         uno::Reference< lang::XComponent > xComponent = 
loadFromDesktop(aFileName);
diff --git a/dbaccess/qa/extras/empty-stdlib-save.cxx 
b/dbaccess/qa/extras/empty-stdlib-save.cxx
index 2ffbccaa6131..440fc19d4945 100644
--- a/dbaccess/qa/extras/empty-stdlib-save.cxx
+++ b/dbaccess/qa/extras/empty-stdlib-save.cxx
@@ -47,12 +47,6 @@ DialogSaveTest::DialogSaveTest()
 
 void DialogSaveTest::test()
 {
-    // UnoApiTest::setUp (via InitVCL) puts each test under a locked 
SolarMutex,
-    // but at least the below xDocCloseable->close call could lead to a 
deadlock
-    // then, and it looks like none of the code here requires the SolarMutex to
-    // be locked anyway:
-    SolarMutexReleaser rel;
-
     const OUString 
aFileName(m_directories.getURLFromWorkdir(u"CppunitTest/testEmptyStdlibSave.odb"));
     {
         uno::Reference< lang::XComponent > xComponent = 
loadFromDesktop(aFileName);
diff --git a/dbaccess/qa/extras/nolib-save.cxx 
b/dbaccess/qa/extras/nolib-save.cxx
index f64e0fbece10..59fee844fd78 100644
--- a/dbaccess/qa/extras/nolib-save.cxx
+++ b/dbaccess/qa/extras/nolib-save.cxx
@@ -47,12 +47,6 @@ DialogSaveTest::DialogSaveTest()
 
 void DialogSaveTest::test()
 {
-    // UnoApiTest::setUp (via InitVCL) puts each test under a locked 
SolarMutex,
-    // but at least the below xDocCloseable->close call could lead to a 
deadlock
-    // then, and it looks like none of the code here requires the SolarMutex to
-    // be locked anyway:
-    SolarMutexReleaser rel;
-
     const OUString 
aFileName(m_directories.getURLFromWorkdir(u"CppunitTest/testNolibSave.odb"));
     {
         uno::Reference< lang::XComponent > xComponent = 
loadFromDesktop(aFileName);

Reply via email to