[Libreoffice-commits] core.git: oox/source

[Caolán McNamara (via logerrit)]

 oox/source/ppt/layoutfragmenthandler.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8b4c152a93d75658a2209089a4058daf5f7a5ff2
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Fri Mar 4 14:03:07 2022 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Fri Mar 4 17:16:48 2022 +0100

    cid#1500690 Explicit null dereferenced
    
    this may stem from:
    commit fcc31cd0e0a6544a13dac0fdc66005d77f6f5cf9
    Date:   Fri Sep 7 18:41:58 2018 +0200
        Revert "clang-tidy performance-move-const-arg"
    
        This reverts commit 3d604d1cd6cc70ef96782ef769f0479b509987a8.
    which didn't 100% revert 3d604d1cd6cc70ef96782ef769f0479b509987a8
    
    so we went from:
    
    LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const 
OUString& rFragmentPath, SlidePersistPtr pMasterPersistPtr)
    : SlideFragmentHandler( rFilter, rFragmentPath, 
std::move(pMasterPersistPtr), Layout )
    
    to
    
    LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const 
OUString& rFragmentPath, const SlidePersistPtr& pMasterPersistPtr)
    : SlideFragmentHandler(rFilter, rFragmentPath, 
std::move(pMasterPersistPtr), Layout)
    
    Change-Id: I90cb437c467f88c75d248ed138d078bf56705a21
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130989
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
    Reviewed-by: Caolán McNamara <caol...@redhat.com>
    Tested-by: Jenkins

diff --git a/oox/source/ppt/layoutfragmenthandler.cxx 
b/oox/source/ppt/layoutfragmenthandler.cxx
index f04a96bb4636..9d95b6ecc5b6 100644
--- a/oox/source/ppt/layoutfragmenthandler.cxx
+++ b/oox/source/ppt/layoutfragmenthandler.cxx
@@ -36,7 +36,7 @@ namespace oox::ppt {
 
 LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const 
OUString& rFragmentPath,
                                              const SlidePersistPtr& 
pMasterPersistPtr)
-    : SlideFragmentHandler(rFilter, rFragmentPath, 
std::move(pMasterPersistPtr), Layout)
+    : SlideFragmentHandler(rFilter, rFragmentPath, pMasterPersistPtr, Layout)
 {
 }