[Libreoffice-commits] core.git: sd/qa

[Xisco Fauli (via logerrit)]

 sd/qa/unit/PNGExportTests.cxx |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit d934f6db87afa61ce4ad6c5fb6b4e5ab842cac8a
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Wed Feb 2 18:18:35 2022 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Fri Feb 4 12:10:06 2022 +0100

    CppunitTest_sd_png_export_tests: fix order of arguments
    
    nY goes first. See include/vcl/BitmapReadAccess.hxx
    
    Change-Id: I1af00102d2267017b98e6b6e286f2eda74f9ca24
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129374
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/sd/qa/unit/PNGExportTests.cxx b/sd/qa/unit/PNGExportTests.cxx
index 5f33ac3d5ebc..72f37c968e53 100644
--- a/sd/qa/unit/PNGExportTests.cxx
+++ b/sd/qa/unit/PNGExportTests.cxx
@@ -96,8 +96,8 @@ CPPUNIT_TEST_FIXTURE(SdPNGExportTest, testTdf105998)
         Bitmap::ScopedReadAccess pReadAccess(aBMP);
         for (tools::Long nX = 1; nX < aSize.Width() - 1; ++nX)
         {
-            const Color aColorTop = pReadAccess->GetColor(nX, 0);
-            const Color aColorBottom = pReadAccess->GetColor(nX, 
aSize.Height() - 1);
+            const Color aColorTop = pReadAccess->GetColor(0, nX);
+            const Color aColorBottom = pReadAccess->GetColor(aSize.Height() - 
1, nX);
 
             assertColorsAreSimilar(COL_LIGHTRED, aColorTop, 5);
 
@@ -109,8 +109,8 @@ CPPUNIT_TEST_FIXTURE(SdPNGExportTest, testTdf105998)
 
         for (tools::Long nY = 1; nY < aSize.Height() - 1; ++nY)
         {
-            const Color aColorLeft = pReadAccess->GetColor(0, nY);
-            const Color aColorRight = pReadAccess->GetColor(aSize.Width() - 1, 
nY);
+            const Color aColorLeft = pReadAccess->GetColor(nY, 0);
+            const Color aColorRight = pReadAccess->GetColor(nY, aSize.Width() 
- 1);
 
             assertColorsAreSimilar(COL_LIGHTRED, aColorLeft, 5);
             assertColorsAreSimilar(COL_LIGHTRED, aColorRight, 5);
@@ -165,7 +165,7 @@ CPPUNIT_TEST_FIXTURE(SdPNGExportTest, testTdf113163)
                 // Without the fix in place, this test would have failed with
                 // - Expected: 0
                 // - Actual  : 16777215
-                const Color aColor = pReadAccess->GetColor(nX, nY);
+                const Color aColor = pReadAccess->GetColor(nY, nX);
                 CPPUNIT_ASSERT_EQUAL(COL_BLACK, aColor);
             }
         }
@@ -218,7 +218,7 @@ CPPUNIT_TEST_FIXTURE(SdPNGExportTest, testTdf147119)
                 // Without the fix in place, this test would have failed with
                 // - Expected: Color: R:255 G:255 B:255 A:0
                 // - Actual  : Color: R:0 G:0 B:0 A:0
-                const Color aColor = pReadAccess->GetColor(nX, nY);
+                const Color aColor = pReadAccess->GetColor(nY, nX);
                 CPPUNIT_ASSERT_EQUAL(COL_WHITE, aColor);
             }
         }