[Libreoffice-commits] core.git: connectivity/source

[Miklos Vajna (via logerrit)]

 connectivity/source/drivers/writer/WDatabaseMetaData.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a4d770731f4e5228ef1101c286d1815cf94a1fd9
Author:     Miklos Vajna <vmik...@collabora.com>
AuthorDate: Thu Jan 13 20:09:57 2022 +0100
Commit:     Miklos Vajna <vmik...@collabora.com>
CommitDate: Fri Jan 14 08:27:33 2022 +0100

    connectivity: can avoid copying here
    
    aTableNames is not changed till we hold a reference to that name.
    
    Change-Id: I8a06b5bead101cba4e3293f6c29a849e7a9d0f6c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128396
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmik...@collabora.com>

diff --git a/connectivity/source/drivers/writer/WDatabaseMetaData.cxx 
b/connectivity/source/drivers/writer/WDatabaseMetaData.cxx
index e9b230be3fb5..f944d86a7fa9 100644
--- a/connectivity/source/drivers/writer/WDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/writer/WDatabaseMetaData.cxx
@@ -90,12 +90,12 @@ uno::Reference<sdbc::XResultSet> SAL_CALL 
OWriterDatabaseMetaData::getTables(
     sal_Int32 nTableCount = aTableNames.getLength();
     for (sal_Int32 nTable = 0; nTable < nTableCount; nTable++)
     {
-        OUString aName = aTableNames[nTable];
-        if (match(tableNamePattern, aName, '\0'))
+        const OUString& rName = aTableNames[nTable];
+        if (match(tableNamePattern, rName, '\0'))
         {
             ODatabaseMetaDataResultSet::ORow aRow{ nullptr, nullptr, nullptr };
             aRow.reserve(6);
-            aRow.push_back(new ORowSetValueDecorator(aName));
+            aRow.push_back(new ORowSetValueDecorator(rName));
             aRow.push_back(new ORowSetValueDecorator(aTable));
             aRow.push_back(ODatabaseMetaDataResultSet::getEmptyValue());
             aRows.push_back(aRow);