Hello. (Ux folks, please advise on the "UX/Localization" section below).
Bug: ==== https://bugs.freedesktop.org/show_bug.cgi?id=34772 Patch: ===== https://bugs.freedesktop.org/attachment.cgi?id=61962 Patch review: =========== https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=34772&attachment=61962 Changes (copied from patch): ======================== This change adds a new status bar control, "SwWordCountStatusBarControl". The control shows the number of words selected as well as the number of words in the whole document. Double-clicking the control launches the modeless word count dialog. Verification: ========== I tested with small documents (to the tune of 30 pages, ~3500 words). I'd like to try it out on a large/huge document to make sure there's no performance impact. Are there any standard "large" documents used for LO performance testing? UX/Localization: ============= Currently the status bar displays counts in the form: "Words: <number-of-selected-words>/<total-number-of-words>". It's not clear at a glance what the numbers mean. It looks like this: http://imgur.com/3WqVD How do you suggest we go about displaying this information clearly, hopefully without being overly verbose? Also, I'm not sure how localizable string literals are handled in the code base. Does LO use something like gettext, or do I have to explicitly add a string resource and load it? Open Issues/Questions: ==================== * What's the point of viewsh.sdi? (compared to _viewsh.sdi). _viewsh.sdi seems to be referencing the methods actually getting invoked for word-count related logic. * swriter.sdi: I based the entry for StateWordCount on StatePageCount. I'm not sure what the fields mean (e.g. StatusBarConfig). * How do I update LO help with material for the new status bar field? I can see that other controls have their own documentation pages (e.g. helpcontent2/source/text/swriter/02/08010000.xhp documents the page count control), but I don't know what template the files follow or what the fields mean. This is what I have so far: https://bugs.freedesktop.org/attachment.cgi?id=61963 Regards, --Muhammad _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
