[Libreoffice-commits] core.git: comphelper/source include/comphelper

[Mike Kaganski (via logerrit)]

 comphelper/source/misc/compbase.cxx |    5 -----
 include/comphelper/compbase.hxx     |    1 -
 2 files changed, 6 deletions(-)

New commits:
commit 9f5188173a4a37a9d41ee90a5555874f1f17136e
Author:     Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Sat Dec 25 19:29:32 2021 +0100
Commit:     Jan-Marek Glogowski <glo...@fbihome.de>
CommitDate: Sat Dec 25 23:35:39 2021 +0100

    Revert "Init WeakComponentImplHelperBase::m_bDisposed"
    
    This reverts commit c1f21a6ce6491ac82a022502c618e2758d3b3a31.
    
    Reason for revert: a better fix is implemented in commit
    f0c0c62c10e4ffdb9ce44202e2540d2f39a9fcb5
        author      Noel Grandin <noel.gran...@collabora.co.uk>
        date        Sat Dec 25 11:43:11 2021 +0200
        uninitialised field in comphelper::WeakComponentImplHelperBase
    
    That change allows to keep the ctor implicitly defined and inline.
    
    Change-Id: Icb8064ebc77d4120d279d30df5de4ebee5479b4b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127474
    Tested-by: Jenkins
    Reviewed-by: Jan-Marek Glogowski <glo...@fbihome.de>

diff --git a/comphelper/source/misc/compbase.cxx 
b/comphelper/source/misc/compbase.cxx
index b8a207ceedb1..6e2019a255ae 100644
--- a/comphelper/source/misc/compbase.cxx
+++ b/comphelper/source/misc/compbase.cxx
@@ -11,11 +11,6 @@
 
 namespace comphelper
 {
-WeakComponentImplHelperBase::WeakComponentImplHelperBase()
-    : m_bDisposed(false)
-{
-}
-
 WeakComponentImplHelperBase::~WeakComponentImplHelperBase() {}
 
 // css::lang::XComponent
diff --git a/include/comphelper/compbase.hxx b/include/comphelper/compbase.hxx
index ce3e44b3732e..5b7e1f7ba7a1 100644
--- a/include/comphelper/compbase.hxx
+++ b/include/comphelper/compbase.hxx
@@ -31,7 +31,6 @@ class COMPHELPER_DLLPUBLIC WeakComponentImplHelperBase : 
public cppu::OWeakObjec
                                                          public 
css::lang::XComponent
 {
 public:
-    WeakComponentImplHelperBase();
     virtual ~WeakComponentImplHelperBase() override;
 
     // css::lang::XComponent