dev/null                                            |binary
 sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py |  127 --------------------
 2 files changed, 127 deletions(-)

New commits:
commit 793d4596d0facf5fc361fe2170bb73e01c60c9c7
Author:     Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Thu Dec 16 22:35:40 2021 +0100
Commit:     Stephan Bergmann <sberg...@redhat.com>
CommitDate: Fri Dec 17 08:51:04 2021 +0100

    Revert brittle UITest for now
    
    UITest_writer_tests2
    
UITEST_TEST_NAME=ComplexGroupShapeTest.ComplexGroupShapeTest.test_ComplexGroupShape,
    introduced with e5650de86072b9db586a4532b5239acda77598c4 "tdf#143574 sw:
    textboxes in group shapes - part 3 take 2", is apparently brittle and often
    fails with
    
    > ERROR: test_ComplexGroupShape 
(ComplexGroupShapeTest.ComplexGroupShapeTest)
    > ----------------------------------------------------------------------
    > Traceback (most recent call last):
    >   File 
"/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py",
 line 96, in test_ComplexGroupShape
    >     
self.assertEqual(True,document.getCurrentSelection().getByIndex(0).TextBox)
    > AttributeError: TextBox
    
    in (slow) ASan+UBSan builds like 
<https://ci.libreoffice.org//job/lo_ubsan/2232>
    as well as in (fast) Flatpak `make check` test builds like
    <https://flathub.org/builds/#/builders/32/builds/71183>.
    
    There is work going on at <https://gerrit.libreoffice.org/c/core/+/126861>
    "[WIP]Sw: Replace PyUITests with CPPUnit ones" to fix that, so remove the 
test
    for now until that fix is ready, to get the various failing builds unstuck.
    
    Change-Id: I3579cedce35e1373c04f976a1a57ac98f1f33448
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126990
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/sw/qa/uitest/data/ComplexGroupShapeTest.odt 
b/sw/qa/uitest/data/ComplexGroupShapeTest.odt
deleted file mode 100644
index 8fe093203690..000000000000
Binary files a/sw/qa/uitest/data/ComplexGroupShapeTest.odt and /dev/null differ
diff --git a/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py 
b/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py
deleted file mode 100644
index 7e219d8d7976..000000000000
--- a/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py
+++ /dev/null
@@ -1,127 +0,0 @@
-# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-from uitest.framework import UITestCase
-from uitest.uihelper.common import get_state_as_dict
-from uitest.uihelper.common import select_pos
-from uitest.uihelper.common import get_url_for_data_file
-from libreoffice.uno.propertyvalue import mkPropertyValues
-import time
-
-class ComplexGroupShapeTest(UITestCase):
-    def test_ComplexGroupShape(self):
-        with 
self.ui_test.load_file(get_url_for_data_file("ComplexGroupShapeTest.odt")):
-            xWriterDoc = self.xUITest.getTopFocusWindow()
-            xWriterEdit = xWriterDoc.getChild("writer_edit")
-            document = self.ui_test.get_component()
-
-            # check the shape type
-            self.assertEqual("com.sun.star.drawing.GroupShape", 
document.DrawPage.getByIndex(1).ShapeType)
-
-            # select the shape
-            self.xUITest.executeCommand(".uno:JumpToNextFrame")
-            self.ui_test.wait_until_child_is_available('metricfield')
-
-            # go inside the group
-            self.xUITest.executeCommand(".uno:EnterGroup")
-
-            # select a shape in the group
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-
-            # add a textbox to this subshape
-            self.xUITest.executeCommand(".uno:AddTextBox")
-
-            # select the next shape in the group
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-
-            # add a textbox to this subshape
-            self.xUITest.executeCommand(".uno:AddTextBox")
-
-            # leave the groupshape
-            self.xUITest.executeCommand(".uno:LeaveGroup")
-
-            # select the other shape
-            self.xUITest.executeCommand(".uno:JumpToNextFrame")
-            self.ui_test.wait_until_child_is_available('metricfield')
-
-            # get the current selection
-            ShapeCollection = document.getCurrentSelection()
-
-            # extend the selection with the grouped shape
-            ShapeCollection.add(document.DrawPage.getByIndex(0))
-            ShapeCollection.add(document.DrawPage.getByIndex(1))
-
-            # select these shapes
-            document.getCurrentController().select(ShapeCollection)
-
-            # do ungroup
-            self.xUITest.executeCommand(".uno:FormatGroup")
-
-            # deselect
-            xWriterEdit.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"ESC"}))
-            time.sleep(0.1)
-
-            # select the group
-            self.xUITest.executeCommand(".uno:JumpToNextFrame")
-            self.ui_test.wait_until_child_is_available('metricfield')
-
-            # move it down
-            for i in range(1, 30):
-                xWriterEdit.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"DOWN"}))
-                time.sleep(0.1)
-
-            # select again
-            self.xUITest.executeCommand(".uno:JumpToNextFrame")
-            self.ui_test.wait_until_child_is_available('metricfield')
-
-            # do ungroup
-            self.xUITest.executeCommand(".uno:FormatUngroup")
-
-            # deselect everything
-            xWriterEdit.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"ESC"}))
-            time.sleep(0.1)
-
-            # select the first ex-group member shape
-            self.xUITest.executeCommand(".uno:JumpToNextFrame")
-            self.ui_test.wait_until_child_is_available('metricfield')
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-
-            # check if it is a textbox
-            
self.assertEqual(True,document.getCurrentSelection().getByIndex(0).TextBox)
-
-            # go to the other one
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-
-            # this is still a group, so it cannot be a textbox
-            
self.assertEqual(False,document.getCurrentSelection().getByIndex(0).TextBox)
-
-            # do ungroup
-            self.xUITest.executeCommand(".uno:FormatUngroup")
-
-            # deselect
-            xWriterEdit.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"ESC"}))
-            time.sleep(0.1)
-
-            # select one shape of the last group
-            self.xUITest.executeCommand(".uno:JumpToNextFrame")
-            self.ui_test.wait_until_child_is_available('metricfield')
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-            xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-
-            # check if it is a textbox
-            
self.assertEqual(True,document.getCurrentSelection().getByIndex(0).TextBox)
-
-            # Without the fix in place, the following problems occurred during 
this test:
-            # - After the grouping old textbox frames detached from their 
shape before
-            # - Moving caused messed layout
-            # - After ungroup, the shapes in the embed group lost their textbox
-
-# vim: set shiftwidth=4 softtabstop=4 expandtab:

Reply via email to