[Libreoffice-commits] core.git: sc/source vcl/source

[Armin Le Grand (Allotropia) (via logerrit)]

 sc/source/ui/view/gridwin.cxx |   11 +++++++++--
 vcl/source/window/winproc.cxx |    7 +++++++
 2 files changed, 16 insertions(+), 2 deletions(-)

New commits:
commit 110d3504c1f738a1d7f740cc212064dafa4fb224
Author:     Armin Le Grand (Allotropia) <armin.le.gr...@me.com>
AuthorDate: Thu Dec 9 16:13:12 2021 +0100
Commit:     Armin Le Grand <armin.le.gr...@me.com>
CommitDate: Fri Dec 10 11:31:23 2021 +0100

    tdf#127341 Do not activate TextEdit at right-klick on URL in calc
    
    Change-Id: I1881c007a05f56d5cb7914da56243f551c2da1cc
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126618
    Tested-by: Jenkins
    Reviewed-by: Armin Le Grand <armin.le.gr...@me.com>

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 6d832990f271..e2f3a1e81e2b 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -3237,8 +3237,15 @@ void ScGridWindow::Command( const CommandEvent& rCEvt )
 
     if ( !bEdit )
     {
-            // Edit cell with spelling errors ?
-        if (bMouse && (GetEditUrl(aPosPixel) || bSpellError))
+        // Edit cell with spelling errors ?
+        // tdf#127341 the formally used GetEditUrl(aPosPixel) addiionally
+        // to bSpellError acivated EditMode here for right-click on URL
+        // which prevents the regular contex-menu from appearing. Since this
+        // is more expeced than the context-menu for editing an URL I removed
+        // this. If this was wanted and can be argued his migh be re-acivated.
+        // For now, reduce to spelling errors - as the original comment above
+        // suggests.
+        if (bMouse && bSpellError)
         {
             //  GetEditUrlOrError has already moved the Cursor
 
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index 1c7d615db77c..9c49f52894c5 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -265,6 +265,13 @@ bool ImplHandleMouseEvent( const VclPtr<vcl::Window>& 
xWindow, MouseNotifyEvent
                            tools::Long nX, tools::Long nY, sal_uInt64 nMsgTime,
                            sal_uInt16 nCode, MouseEventModifiers nMode )
 {
+    SAL_INFO( "vcl.debugevent",
+              "mouse event "
+               "(MouseNotifyEvent " << static_cast<sal_uInt16>(nSVEvent) << ") 
"
+               "(MouseLeave " << bMouseLeave << ") "
+               "(X, Y " << nX << ", " << nY << ") "
+               "(Code " << nCode << ") "
+               "(Modifiers " << static_cast<sal_uInt16>(nMode) << ")");
     ImplSVHelpData& aHelpData = ImplGetSVHelpData();
     ImplSVData* pSVData = ImplGetSVData();
     Point       aMousePos( nX, nY );