[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/filter/lotus/op.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 5b2164973dd09df775d7bd4fe1d97d521059fa2b
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Thu Dec 9 12:06:50 2021 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Thu Dec 9 17:51:34 2021 +0100

    cid#1242728 Untrusted value as argument
    
    and
    
    cid#1494650 Untrusted value as argument
    
    where we have validated the cell address
    
    Change-Id: I924aac1e24c6577b8fa9f8fa53e6169e9143d104
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126583
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/sc/source/filter/lotus/op.cxx b/sc/source/filter/lotus/op.cxx
index 14f4cf327ed8..33d336d0fb17 100644
--- a/sc/source/filter/lotus/op.cxx
+++ b/sc/source/filter/lotus/op.cxx
@@ -159,6 +159,7 @@ void OP_Formula(LotusContext &rContext, SvStream& r, 
sal_uInt16 /*n*/)
         ScFormulaCell* pCell = new ScFormulaCell(rContext.rDoc, aAddress, 
std::move(pResult));
         pCell->AddRecalcMode( ScRecalcMode::ONLOAD_ONCE );
         rContext.rDoc.EnsureTable(0);
+        // coverity[tainted_data : FALSE] - ValidColRow has sanitized aAddr
         rContext.rDoc.SetFormulaCell(ScAddress(nCol, nRow, 0), pCell);
 
         // nFormat = Default -> number of digits in fractional part like Float
@@ -422,6 +423,7 @@ void OP_Formula123(LotusContext& rContext, SvStream& r, 
sal_uInt16 n)
         ScFormulaCell* pCell = new ScFormulaCell(rContext.rDoc, aAddress, 
std::move(pResult));
         pCell->AddRecalcMode( ScRecalcMode::ONLOAD_ONCE );
         rContext.rDoc.EnsureTable(nTab);
+        // coverity[tainted_data : FALSE] - ValidAddress has sanitized aAddr
         rContext.rDoc.SetFormulaCell(aAddress, pCell);
     }
 }