[Libreoffice-commits] core.git: sd/qa

[Henrik Palomäki (via logerrit)]

 sd/qa/unit/uiimpress.cxx |   16 ----------------
 1 file changed, 16 deletions(-)

New commits:
commit 0935a53a1ef70d0cbaef5fbfe2a0bc2f3ddfeafd
Author:     Henrik Palomäki <henrik.palom...@yandex.com>
AuthorDate: Tue Nov 2 09:37:15 2021 +0200
Commit:     Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
CommitDate: Tue Nov 2 17:01:56 2021 +0100

    tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
    
    Change-Id: I0b95ad5d1e46ed04717d7dccec7c6621b5d4d1e1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124595
    Tested-by: Jenkins
    Tested-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
    Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>

diff --git a/sd/qa/unit/uiimpress.cxx b/sd/qa/unit/uiimpress.cxx
index f4fa936f7bde..f692bd66a022 100644
--- a/sd/qa/unit/uiimpress.cxx
+++ b/sd/qa/unit/uiimpress.cxx
@@ -242,8 +242,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf124708)
 {
     mxComponent = 
loadFromDesktop(m_directories.getURLFromSrc(u"sd/qa/unit/data/tdf124708.ppt"));
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     dispatchCommand(mxComponent, ".uno:NextPage", {});
     Scheduler::ProcessEventsToIdle();
 
@@ -274,8 +272,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf143412)
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     auto pXImpressDocument = 
dynamic_cast<SdXImpressDocument*>(mxComponent.get());
     sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
 
@@ -315,8 +311,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf139996)
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     sd::slidesorter::SlideSorterViewShell* pSSVS = getSlideSorterViewShell();
     auto& rSSController = pSSVS->GetSlideSorter().GetController();
     auto& rPageSelector = rSSController.GetPageSelector();
@@ -384,8 +378,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf100950)
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     dispatchCommand(mxComponent, ".uno:InsertPage", {});
     Scheduler::ProcessEventsToIdle();
 
@@ -410,8 +402,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf129346)
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     dispatchCommand(mxComponent, ".uno:DiaMode", {});
     Scheduler::ProcessEventsToIdle();
     checkCurrentPageNumber(1);
@@ -430,8 +420,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testmoveSlides)
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     auto pXImpressDocument = 
dynamic_cast<SdXImpressDocument*>(mxComponent.get());
     sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
 
@@ -494,7 +482,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf141703)
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
 
-    CPPUNIT_ASSERT(mxComponent.is());
     auto pXImpressDocument = 
dynamic_cast<SdXImpressDocument*>(mxComponent.get());
 
     uno::Sequence<beans::PropertyValue> aArgs(comphelper::InitPropertySequence(
@@ -557,8 +544,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf127481)
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     auto pXImpressDocument = 
dynamic_cast<SdXImpressDocument*>(mxComponent.get());
     sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
     SdPage* pActualPage = pViewShell->GetActualPage();
@@ -763,7 +748,6 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testTdf142589)
 {
     mxComponent = loadFromDesktop("private:factory/simpress",
                                   
"com.sun.star.presentation.PresentationDocument");
-    CPPUNIT_ASSERT(mxComponent.is());
 
     auto pImpressDocument = 
dynamic_cast<SdXImpressDocument*>(mxComponent.get());
     sd::ViewShell* pViewShell = 
pImpressDocument->GetDocShell()->GetViewShell();