svx/uiconfig/ui/toolbarpopover.ui | 2 --
1 file changed, 2 deletions(-)
New commits:
commit a93329244a7d24b8a89d8f287b6123e56d13786d
Author: Caolán McNamara <caol...@redhat.com>
AuthorDate: Thu Oct 28 14:23:36 2021 +0100
Commit: Caolán McNamara <caol...@redhat.com>
CommitDate: Thu Oct 28 18:14:05 2021 +0200
gtk[3 vs 4]: remove can-focus entirely from toolbarpopover.ui
so tab-cycling inside sidebar popovers work as wanted
In gtk3 a can-focus of True means that tab-cycling doesn't work
correctly as the container is seen as a candidate itself
In gtk4 a can-focus of False means that focus cannot enter any
child of it.
So it needs to be false for gtk3 and true for gtk4, leaving it
unspecified gets a desired working default.
Change-Id: I423094657854ed02bc28496dfc9a30efa1e945da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124338
Tested-by: Caolán McNamara <caol...@redhat.com>
Reviewed-by: Caolán McNamara <caol...@redhat.com>
diff --git a/svx/uiconfig/ui/toolbarpopover.ui
b/svx/uiconfig/ui/toolbarpopover.ui
index 3a0f83bf3405..d7684d73ebe7 100644
--- a/svx/uiconfig/ui/toolbarpopover.ui
+++ b/svx/uiconfig/ui/toolbarpopover.ui
@@ -3,13 +3,11 @@
<interface domain="svx">
<requires lib="gtk+" version="3.20"/>
<object class="GtkPopover" id="ToolbarPopover">
- <property name="can-focus">True</property>
<property name="no-show-all">True</property>
<property name="border-width">4</property>
<child>
<object class="GtkBox" id="container">
<property name="visible">True</property>
- <property name="can-focus">True</property>
<property name="orientation">vertical</property>
<property name="spacing">6</property>
<child>
