[Libreoffice-commits] core.git: sc/source

[Michael Weghorn (via logerrit)]

 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cda060d6c340b3d050c823fcaa331d27f4dafb5f
Author:     Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Mon Sep 13 10:57:03 2021 +0200
Commit:     Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Mon Sep 13 12:41:14 2021 +0200

    a11y: Set new tab name in AccessibleEventId::NAME_CHANGED event
    
    The previous use of 'sOldName' instead of 'sNewName' looks like a
    copy paste mistake which would result in "Sheet %1" being
    set for the new name.
    
    cppcheck warned about this:
    "Variable 'sOldName' is assigned a value that is never used.
    
    Change-Id: I8676f42bb6548ce1618d14f84b77541f279bac58
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122023
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>

diff --git a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx 
b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
index 484ab05c0eb6..c8b52475e47e 100644
--- a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
+++ b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
@@ -680,7 +680,7 @@ void ScAccessibleSpreadsheet::Notify( SfxBroadcaster& rBC, 
const SfxHint& rHint
                             sOldName = sOldName.replaceFirst("%1", 
m_strOldTabName);
                             aEvent.OldValue <<= sOldName;
                             OUString sNewName(ScResId(STR_ACC_TABLE_NAME));
-                            sOldName = sNewName.replaceFirst("%1", tabName);
+                            sNewName = sNewName.replaceFirst("%1", tabName);
                             aEvent.NewValue <<= sNewName;
                             CommitChange( aEvent );
                             m_strOldTabName = tabName;