vcl/headless/svpbmp.cxx | 3 --- vcl/headless/svpgdi.cxx | 12 +++--------- vcl/jsdialog/jsdialogbuilder.cxx | 1 - vcl/qt5/Qt5SvpGraphics.cxx | 3 +-- vcl/source/app/svdata.cxx | 3 +-- vcl/source/bitmap/dibtools.cxx | 7 +------ vcl/source/control/DropdownBox.cxx | 1 - vcl/source/control/button.cxx | 4 ++-- vcl/source/control/quickselectionengine.cxx | 3 --- vcl/source/filter/eps/eps.cxx | 11 ----------- vcl/source/filter/idxf/dxfgrprd.cxx | 1 - vcl/source/filter/idxf/dxfvec.cxx | 8 +++----- vcl/source/filter/imet/ios2met.cxx | 6 ------ vcl/source/font/font.cxx | 6 +++--- vcl/source/gdi/gradient.cxx | 3 +-- vcl/source/gdi/graphictools.cxx | 11 ++--------- vcl/source/gdi/hatch.cxx | 2 +- vcl/source/gdi/lineinfo.cxx | 2 +- vcl/source/gdi/mapmod.cxx | 2 +- vcl/source/gdi/region.cxx | 25 +++++-------------------- vcl/source/gdi/salgdilayout.cxx | 1 - vcl/source/gdi/sallayout.cxx | 3 +-- vcl/source/gdi/vectorgraphicdata.cxx | 6 ------ vcl/source/graphic/GraphicObject2.cxx | 2 +- vcl/source/graphic/UnoGraphic.cxx | 3 +-- vcl/source/helper/canvasbitmap.cxx | 4 ---- vcl/source/helper/threadex.cxx | 4 +--- vcl/source/image/ImplImage.cxx | 1 - vcl/source/treelist/svlbitm.cxx | 6 ++---- vcl/source/uitest/logger.cxx | 3 +-- vcl/source/window/OptionalBox.cxx | 1 - vcl/source/window/menu.cxx | 7 ++----- vcl/source/window/printdlg.cxx | 4 ---- vcl/source/window/tabpage.cxx | 1 - vcl/unx/generic/gdi/cairo_xlib_cairo.cxx | 3 --- vcl/unx/generic/gdi/gdiimpl.cxx | 3 +-- vcl/unx/generic/gdi/salgdi.cxx | 1 - vcl/unx/gtk3/gtkdata.cxx | 2 -- vcl/unx/gtk3/gtkinst.cxx | 3 +-- vcl/unx/gtk3/gtksys.cxx | 2 +- vcl/unx/gtk3/salnativewidgets-gtk.cxx | 3 +-- 41 files changed, 38 insertions(+), 139 deletions(-)
New commits: commit 81f6842a7d03f5b93ddcece64ef252cc9adf4350 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Sun Sep 5 15:54:52 2021 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Mon Sep 6 20:53:01 2021 +0200 clang-tidy:readability-redundant-member-init Change-Id: I51f4e8affac41023110042b534a915f096ccd0c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121692 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/vcl/headless/svpbmp.cxx b/vcl/headless/svpbmp.cxx index 29b85a1acf91..167a5165a893 100644 --- a/vcl/headless/svpbmp.cxx +++ b/vcl/headless/svpbmp.cxx @@ -35,9 +35,6 @@ using namespace basegfx; SvpSalBitmap::SvpSalBitmap() -: SalBitmap(), - basegfx::SystemDependentDataHolder(), // MM02 - mpDIB() { } diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx index a80a1317487f..5126abb19385 100644 --- a/vcl/headless/svpgdi.cxx +++ b/vcl/headless/svpgdi.cxx @@ -357,8 +357,7 @@ namespace public: explicit SurfaceHelper() - : pSurface(nullptr), - maDownscaled() + : pSurface(nullptr) { } ~SurfaceHelper() @@ -398,11 +397,9 @@ namespace explicit BitmapHelper( const SalBitmap& rSourceBitmap, const bool bForceARGB32 = false) - : SurfaceHelper(), #ifdef HAVE_CAIRO_FORMAT_RGB24_888 - m_bForceARGB32(bForceARGB32), + : m_bForceARGB32(bForceARGB32) #endif - aTmpBmp() { const SvpSalBitmap& rSrcBmp = static_cast<const SvpSalBitmap&>(rSourceBitmap); #ifdef HAVE_CAIRO_FORMAT_RGB24_888 @@ -513,8 +510,6 @@ namespace public: explicit MaskHelper(const SalBitmap& rAlphaBitmap) - : SurfaceHelper(), - pAlphaBits() { const SvpSalBitmap& rMask = static_cast<const SvpSalBitmap&>(rAlphaBitmap); const BitmapBuffer* pMaskBuf = rMask.GetBuffer(); @@ -1417,8 +1412,7 @@ SystemDependentData_CairoPath::SystemDependentData_CairoPath( : basegfx::SystemDependentData(rSystemDependentDataManager), mpCairoPath(nullptr), mbNoJoin(bNoJoin), - mbAntiAlias(bAntiAlias), - maStroke() + mbAntiAlias(bAntiAlias) { // tdf#129845 only create a copy of the path when nSizeMeasure is // bigger than some decent threshold diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx index c54ea3491f8a..6b6c12831d73 100644 --- a/vcl/jsdialog/jsdialogbuilder.cxx +++ b/vcl/jsdialog/jsdialogbuilder.cxx @@ -50,7 +50,6 @@ JSDialogNotifyIdle::JSDialogNotifyIdle(VclPtr<vcl::Window> aNotifierWindow, , m_aNotifierWindow(aNotifierWindow) , m_aContentWindow(aContentWindow) , m_sTypeOfJSON(sTypeOfJSON) - , m_LastNotificationMessage() , m_bForce(false) { SetPriority(TaskPriority::POST_PAINT); diff --git a/vcl/qt5/Qt5SvpGraphics.cxx b/vcl/qt5/Qt5SvpGraphics.cxx index 9dc9b7e2a5ad..5143114bcb74 100644 --- a/vcl/qt5/Qt5SvpGraphics.cxx +++ b/vcl/qt5/Qt5SvpGraphics.cxx @@ -25,8 +25,7 @@ #include <QtWidgets/QWidget> Qt5SvpGraphics::Qt5SvpGraphics(Qt5Frame* pFrame) - : SvpSalGraphics() - , m_pFrame(pFrame) + : m_pFrame(pFrame) { if (!Qt5Data::noNativeControls()) m_pWidgetDraw.reset(new Qt5Graphics_Controls(*this)); diff --git a/vcl/source/app/svdata.cxx b/vcl/source/app/svdata.cxx index 147d010bdd08..61a766b17e53 100644 --- a/vcl/source/app/svdata.cxx +++ b/vcl/source/app/svdata.cxx @@ -112,8 +112,7 @@ namespace public: SystemDependentDataBuffer(const char* pDebugName) - : basegfx::SystemDependentDataManager(), - maTimer(std::make_unique<AutoTimer>(pDebugName)) + : maTimer(std::make_unique<AutoTimer>(pDebugName)) { maTimer->SetTimeout(1000); maTimer->SetInvokeHandler(LINK(this, SystemDependentDataBuffer, implTimeoutHdl)); diff --git a/vcl/source/bitmap/dibtools.cxx b/vcl/source/bitmap/dibtools.cxx index 296be1dc1def..55e287e44411 100644 --- a/vcl/source/bitmap/dibtools.cxx +++ b/vcl/source/bitmap/dibtools.cxx @@ -67,9 +67,6 @@ struct CIEXYZTriple CIEXYZ aXyzBlue; CIEXYZTriple() - : aXyzRed(), - aXyzGreen(), - aXyzBlue() {} }; @@ -119,13 +116,11 @@ struct DIBV5Header : public DIBInfoHeader sal_uInt32 nV5Reserved; DIBV5Header() - : DIBInfoHeader(), - nV5RedMask(0), + : nV5RedMask(0), nV5GreenMask(0), nV5BlueMask(0), nV5AlphaMask(0), nV5CSType(0), - aV5Endpoints(), nV5GammaRed(0), nV5GammaGreen(0), nV5GammaBlue(0), diff --git a/vcl/source/control/DropdownBox.cxx b/vcl/source/control/DropdownBox.cxx index 5df91b7304e4..6aaf2e553ace 100644 --- a/vcl/source/control/DropdownBox.cxx +++ b/vcl/source/control/DropdownBox.cxx @@ -30,7 +30,6 @@ DropdownBox::DropdownBox(vcl::Window* pParent) : VclHBox(pParent) - , IPrioritable() , m_bInFullView(true) { m_pButton = VclPtr<PushButton>::Create(this, WB_FLATBUTTON); diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx index f741ddb133d1..0554bcfb3446 100644 --- a/vcl/source/control/button.cxx +++ b/vcl/source/control/button.cxx @@ -93,8 +93,8 @@ public: rtl::Reference<VclStatusListener<Button>> mpStatusListener; }; -ImplCommonButtonData::ImplCommonButtonData() : maFocusRect(), mnSeparatorX(0), mnButtonState(DrawButtonFlags::NONE), -mbSmallSymbol(false), mbGeneratedTooltip(false), maImage(), meImageAlign(ImageAlign::Top), meSymbolAlign(SymbolAlign::LEFT), maCustomContentImage() +ImplCommonButtonData::ImplCommonButtonData() : mnSeparatorX(0), mnButtonState(DrawButtonFlags::NONE), +mbSmallSymbol(false), mbGeneratedTooltip(false), meImageAlign(ImageAlign::Top), meSymbolAlign(SymbolAlign::LEFT) { } diff --git a/vcl/source/control/quickselectionengine.cxx b/vcl/source/control/quickselectionengine.cxx index e3b060896d5e..290eab55976f 100644 --- a/vcl/source/control/quickselectionengine.cxx +++ b/vcl/source/control/quickselectionengine.cxx @@ -39,9 +39,6 @@ namespace vcl explicit QuickSelectionEngine_Data( ISearchableStringList& _entryList ) :rEntryList( _entryList ) - ,sCurrentSearchString() - ,aSingleSearchChar() - ,aSearchTimeout() { aSearchTimeout.SetTimeout( 2500 ); aSearchTimeout.SetInvokeHandler( LINK( this, QuickSelectionEngine_Data, SearchStringTimeout ) ); diff --git a/vcl/source/filter/eps/eps.cxx b/vcl/source/filter/eps/eps.cxx index 225857d88c0c..5f9765ddce57 100644 --- a/vcl/source/filter/eps/eps.cxx +++ b/vcl/source/filter/eps/eps.cxx @@ -245,28 +245,18 @@ PSWriter::PSWriter() , mnTextMode(0) , mpPS(nullptr) , pMTF(nullptr) - , pVDev() , nBoundingX2(0) , nBoundingY2(0) , pGDIStack(nullptr) , mnCursorPos(0) - , aColor() , bLineColor(false) - , aLineColor() , bFillColor(false) - , aFillColor() - , aTextColor() , bTextFillColor(false) - , aTextFillColor() - , aBackgroundColor() , eTextAlign() , fLineWidth(0) , fMiterLimit(0) , eLineCap() , eJoinType() - , aDashArray() - , maFont() - , maLastFont() , pPrefix(nullptr) , nDataSize(0) , nClearCode(0) @@ -275,7 +265,6 @@ PSWriter::PSWriter() , nCodeSize(0) , nOffset(0) , dwShift(0) - , xStatusIndicator() { } diff --git a/vcl/source/filter/idxf/dxfgrprd.cxx b/vcl/source/filter/idxf/dxfgrprd.cxx index f5d42106c2ad..d951967d7fcb 100644 --- a/vcl/source/filter/idxf/dxfgrprd.cxx +++ b/vcl/source/filter/idxf/dxfgrprd.cxx @@ -109,7 +109,6 @@ DXFGroupReader::DXFGroupReader(SvStream & rIStream) : rIS(rIStream) , bStatus(true) , nLastG(0) - , S() , I(0) { rIS.Seek(0); diff --git a/vcl/source/filter/idxf/dxfvec.cxx b/vcl/source/filter/idxf/dxfvec.cxx index 58b4d1f6e200..168f597597c2 100644 --- a/vcl/source/filter/idxf/dxfvec.cxx +++ b/vcl/source/filter/idxf/dxfvec.cxx @@ -82,7 +82,7 @@ DXFTransform::DXFTransform(double fScaleX, double fScaleY, double fScaleZ, DXFTransform::DXFTransform(const DXFVector & rExtrusion) : - aMX(), aMY(), aMZ(), aMP(0.0, 0.0, 0.0) + aMP(0.0, 0.0, 0.0) { // 'Arbitrary Axis Algorithm' (cf. DXF documentation by Autodesk) if ( fabs(rExtrusion.fx) < 1.0/64.0 && fabs(rExtrusion.fy) < 1.0/64.0) { @@ -97,8 +97,7 @@ DXFTransform::DXFTransform(const DXFVector & rExtrusion) : } -DXFTransform::DXFTransform(const DXFVector & rViewDir, const DXFVector & rViewTarget) : - aMX(), aMY(), aMZ(), aMP() +DXFTransform::DXFTransform(const DXFVector & rViewDir, const DXFVector & rViewTarget) { DXFVector aV; @@ -132,8 +131,7 @@ DXFTransform::DXFTransform(const DXFVector & rViewDir, const DXFVector & rViewTa } -DXFTransform::DXFTransform(const DXFTransform & rT1, const DXFTransform & rT2) : - aMX(),aMY(),aMZ(),aMP() +DXFTransform::DXFTransform(const DXFTransform & rT1, const DXFTransform & rT2) { rT2.TransDir(rT1.aMX,aMX); rT2.TransDir(rT1.aMY,aMY); diff --git a/vcl/source/filter/imet/ios2met.cxx b/vcl/source/filter/imet/ios2met.cxx index 5611da89428d..e6f1058389fd 100644 --- a/vcl/source/filter/imet/ios2met.cxx +++ b/vcl/source/filter/imet/ios2met.cxx @@ -430,19 +430,13 @@ OS2METReader::OS2METReader() : ErrorCode(0) , pOS2MET(nullptr) , pVirDev(VclPtr<VirtualDevice>::Create()) - , aBoundingRect() - , aCalcBndRect() - , aGlobMapMode() , bCoord32(false) , pPaletteStack(nullptr) - , aLineInfo() , pAreaStack(nullptr) , pPathStack(nullptr) , pPathList(nullptr) , pFontList(nullptr) , pBitmapList(nullptr) - , aDefAttr() - , aAttr() , pAttrStack(nullptr) { pVirDev->EnableOutput(false); diff --git a/vcl/source/font/font.cxx b/vcl/source/font/font.cxx index c4fc55300893..275eb5fe97a2 100644 --- a/vcl/source/font/font.cxx +++ b/vcl/source/font/font.cxx @@ -64,20 +64,20 @@ Font::Font( vcl::Font&& rFont ) noexcept : mpImplFont( std::move(rFont.mpImplFon { } -Font::Font( const OUString& rFamilyName, const Size& rSize ) : mpImplFont() +Font::Font( const OUString& rFamilyName, const Size& rSize ) { mpImplFont->SetFamilyName( rFamilyName ); mpImplFont->SetFontSize( rSize ); } -Font::Font( const OUString& rFamilyName, const OUString& rStyleName, const Size& rSize ) : mpImplFont() +Font::Font( const OUString& rFamilyName, const OUString& rStyleName, const Size& rSize ) { mpImplFont->SetFamilyName( rFamilyName ); mpImplFont->SetStyleName( rStyleName ); mpImplFont->SetFontSize( rSize ); } -Font::Font( FontFamily eFamily, const Size& rSize ) : mpImplFont() +Font::Font( FontFamily eFamily, const Size& rSize ) { mpImplFont->SetFamilyType( eFamily ); mpImplFont->SetFontSize( rSize ); diff --git a/vcl/source/gdi/gradient.cxx b/vcl/source/gdi/gradient.cxx index 40a4f94d7204..899861cfc222 100644 --- a/vcl/source/gdi/gradient.cxx +++ b/vcl/source/gdi/gradient.cxx @@ -84,8 +84,7 @@ Gradient::Gradient( const Gradient& ) = default; Gradient::Gradient( Gradient&& ) = default; Gradient::Gradient( GradientStyle eStyle, - const Color& rStartColor, const Color& rEndColor ) : - mpImplGradient() + const Color& rStartColor, const Color& rEndColor ) { mpImplGradient->meStyle = eStyle; mpImplGradient->maStartColor = rStartColor; diff --git a/vcl/source/gdi/graphictools.cxx b/vcl/source/gdi/graphictools.cxx index aaff941a3507..1a2442d1b2d2 100644 --- a/vcl/source/gdi/graphictools.cxx +++ b/vcl/source/gdi/graphictools.cxx @@ -29,15 +29,11 @@ SvtGraphicFill::Transform::Transform() } SvtGraphicStroke::SvtGraphicStroke() : - maPath(), - maStartArrow(), - maEndArrow(), mfTransparency(), mfStrokeWidth(), maCapType(), maJoinType(), - mfMiterLimit( 3.0 ), - maDashArray() + mfMiterLimit( 3.0 ) { } @@ -161,20 +157,17 @@ SvStream& ReadSvtGraphicStroke( SvStream& rIStm, SvtGraphicStroke& rClass ) } SvtGraphicFill::SvtGraphicFill() : - maPath(), maFillColor( COL_BLACK ), mfTransparency(), maFillRule(), maFillType(), - maFillTransform(), mbTiling( false ), maHatchType(), maHatchColor( COL_BLACK ), maGradientType(), maGradient1stColor( COL_BLACK ), maGradient2ndColor( COL_BLACK ), - maGradientStepCount( gradientStepsInfinite ), - maFillGraphic() + maGradientStepCount( gradientStepsInfinite ) { } diff --git a/vcl/source/gdi/hatch.cxx b/vcl/source/gdi/hatch.cxx index 4adbd035fa52..cfb273367742 100644 --- a/vcl/source/gdi/hatch.cxx +++ b/vcl/source/gdi/hatch.cxx @@ -43,7 +43,7 @@ Hatch::Hatch() = default; Hatch::Hatch( const Hatch& ) = default; Hatch::Hatch( HatchStyle eStyle, const Color& rColor, - tools::Long nDistance, Degree10 nAngle10 ) : mpImplHatch() + tools::Long nDistance, Degree10 nAngle10 ) { mpImplHatch->maColor = rColor; mpImplHatch->meStyle = eStyle; diff --git a/vcl/source/gdi/lineinfo.cxx b/vcl/source/gdi/lineinfo.cxx index 27f4e408f95f..94ab3b83df65 100644 --- a/vcl/source/gdi/lineinfo.cxx +++ b/vcl/source/gdi/lineinfo.cxx @@ -53,7 +53,7 @@ inline bool ImplLineInfo::operator==( const ImplLineInfo& rB ) const } -LineInfo::LineInfo( LineStyle eStyle, double nWidth ) : mpImplLineInfo() +LineInfo::LineInfo( LineStyle eStyle, double nWidth ) { mpImplLineInfo->meStyle = eStyle; mpImplLineInfo->mnWidth = nWidth; diff --git a/vcl/source/gdi/mapmod.cxx b/vcl/source/gdi/mapmod.cxx index c79a4392d1a8..2a61b271df9b 100644 --- a/vcl/source/gdi/mapmod.cxx +++ b/vcl/source/gdi/mapmod.cxx @@ -77,7 +77,7 @@ MapMode::MapMode() : mpImplMapMode(GetGlobalDefault()) MapMode::MapMode( const MapMode& ) = default; -MapMode::MapMode( MapUnit eUnit ) : mpImplMapMode() +MapMode::MapMode( MapUnit eUnit ) { mpImplMapMode->meUnit = eUnit; } diff --git a/vcl/source/gdi/region.cxx b/vcl/source/gdi/region.cxx index 2dbea8db1f0d..7acf33a53533 100644 --- a/vcl/source/gdi/region.cxx +++ b/vcl/source/gdi/region.cxx @@ -308,27 +308,18 @@ basegfx::B2DPolyPolygon vcl::Region::ImplCreateB2DPolyPolygonFromRegionBand() co } Region::Region(bool bIsNull) -: mpB2DPolyPolygon(), - mpPolyPolygon(), - mpRegionBand(), - mbIsNull(bIsNull) +: mbIsNull(bIsNull) { } Region::Region(const tools::Rectangle& rRect) -: mpB2DPolyPolygon(), - mpPolyPolygon(), - mpRegionBand(), - mbIsNull(false) +: mbIsNull(false) { mpRegionBand.reset(rRect.IsEmpty() ? nullptr : new RegionBand(rRect)); } Region::Region(const tools::Polygon& rPolygon) -: mpB2DPolyPolygon(), - mpPolyPolygon(), - mpRegionBand(), - mbIsNull(false) +: mbIsNull(false) { if(rPolygon.GetSize()) @@ -338,10 +329,7 @@ Region::Region(const tools::Polygon& rPolygon) } Region::Region(const tools::PolyPolygon& rPolyPoly) -: mpB2DPolyPolygon(), - mpPolyPolygon(), - mpRegionBand(), - mbIsNull(false) +: mbIsNull(false) { if(rPolyPoly.Count()) @@ -351,10 +339,7 @@ Region::Region(const tools::PolyPolygon& rPolyPoly) } Region::Region(const basegfx::B2DPolyPolygon& rPolyPoly) -: mpB2DPolyPolygon(), - mpPolyPolygon(), - mpRegionBand(), - mbIsNull(false) +: mbIsNull(false) { if(rPolyPoly.count()) diff --git a/vcl/source/gdi/salgdilayout.cxx b/vcl/source/gdi/salgdilayout.cxx index adf26d97d9ac..403779382afc 100644 --- a/vcl/source/gdi/salgdilayout.cxx +++ b/vcl/source/gdi/salgdilayout.cxx @@ -49,7 +49,6 @@ SalFrameGeometry SalFrame::GetGeometry() const SalGraphics::SalGraphics() : m_nLayout( SalLayoutFlags::NONE ), - m_aLastMirror(), m_aLastMirrorW(0), m_nLastMirrorDeviceLTRButBiDiRtlTranslate(0), m_bLastMirrorDeviceLTRButBiDiRtlSet(false), diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx index 7a69defd60f5..45d59517b79a 100644 --- a/vcl/source/gdi/sallayout.cxx +++ b/vcl/source/gdi/sallayout.cxx @@ -585,8 +585,7 @@ void GenericSalLayout::Simplify( bool bIsBase ) } MultiSalLayout::MultiSalLayout( std::unique_ptr<SalLayout> pBaseLayout ) -: SalLayout() -, mnLevel( 1 ) +: mnLevel( 1 ) , mbIncomplete( false ) { assert(dynamic_cast<GenericSalLayout*>(pBaseLayout.get())); diff --git a/vcl/source/gdi/vectorgraphicdata.cxx b/vcl/source/gdi/vectorgraphicdata.cxx index 067df62b8176..bf8f3b508ff6 100644 --- a/vcl/source/gdi/vectorgraphicdata.cxx +++ b/vcl/source/gdi/vectorgraphicdata.cxx @@ -315,9 +315,6 @@ VectorGraphicData::VectorGraphicData( sal_Int32 nPageIndex) : maDataContainer(rDataContainer), mbSequenceCreated(false), - maRange(), - maSequence(), - maReplacement(), mNestedBitmapSize(0), meType(eVectorDataType), mnPageIndex(nPageIndex) @@ -328,9 +325,6 @@ VectorGraphicData::VectorGraphicData( const OUString& rPath, VectorGraphicDataType eVectorDataType) : mbSequenceCreated(false), - maRange(), - maSequence(), - maReplacement(), mNestedBitmapSize(0), meType(eVectorDataType), mnPageIndex(-1) diff --git a/vcl/source/graphic/GraphicObject2.cxx b/vcl/source/graphic/GraphicObject2.cxx index b19fc5e10f02..2c377a96aa99 100644 --- a/vcl/source/graphic/GraphicObject2.cxx +++ b/vcl/source/graphic/GraphicObject2.cxx @@ -28,7 +28,7 @@ struct ImplTileInfo { - ImplTileInfo() : aTileTopLeft(), aNextTileTopLeft(), aTileSizePixel(), nTilesEmptyX(0), nTilesEmptyY(0) {} + ImplTileInfo() : nTilesEmptyX(0), nTilesEmptyY(0) {} Point aTileTopLeft; // top, left position of the rendered tile Point aNextTileTopLeft; // top, left position for next recursion diff --git a/vcl/source/graphic/UnoGraphic.cxx b/vcl/source/graphic/UnoGraphic.cxx index 2e850ef1b5dc..7792f6b17165 100644 --- a/vcl/source/graphic/UnoGraphic.cxx +++ b/vcl/source/graphic/UnoGraphic.cxx @@ -36,8 +36,7 @@ using namespace com::sun::star; namespace unographic { -Graphic::Graphic() : - maGraphic() +Graphic::Graphic() { } diff --git a/vcl/source/helper/canvasbitmap.cxx b/vcl/source/helper/canvasbitmap.cxx index 1e3edd5f3996..68bef1b79b77 100644 --- a/vcl/source/helper/canvasbitmap.cxx +++ b/vcl/source/helper/canvasbitmap.cxx @@ -97,11 +97,7 @@ void VclCanvasBitmap::setComponentInfo( sal_uInt32 redShift, sal_uInt32 greenShi VclCanvasBitmap::VclCanvasBitmap( const BitmapEx& rBitmap ) : m_aBmpEx( rBitmap ), m_aBitmap( rBitmap.GetBitmap() ), - m_aAlpha(), m_pBmpAcc( m_aBitmap ), - m_aComponentTags(), - m_aComponentBitCounts(), - m_aLayout(), m_nBitsPerInputPixel(0), m_nBitsPerOutputPixel(0), m_nRedIndex(-1), diff --git a/vcl/source/helper/threadex.cxx b/vcl/source/helper/threadex.cxx index 838cdf44c40c..1d55ddc08562 100644 --- a/vcl/source/helper/threadex.cxx +++ b/vcl/source/helper/threadex.cxx @@ -23,9 +23,7 @@ using namespace vcl; SolarThreadExecutor::SolarThreadExecutor() - : m_aStart() - , m_aFinish() - , m_bTimeout(false) + : m_bTimeout(false) { } diff --git a/vcl/source/image/ImplImage.cxx b/vcl/source/image/ImplImage.cxx index ba8b85802ac9..6df732c09d97 100644 --- a/vcl/source/image/ImplImage.cxx +++ b/vcl/source/image/ImplImage.cxx @@ -37,7 +37,6 @@ ImplImage::ImplImage(const BitmapEx &rBitmapEx) ImplImage::ImplImage(const OUString &aStockName) : maBitmapChecksum(0) - , maSizePixel() // defer size lookup , maStockName(aStockName) { } diff --git a/vcl/source/treelist/svlbitm.cxx b/vcl/source/treelist/svlbitm.cxx index 0736ee65109c..3e0243a8d944 100644 --- a/vcl/source/treelist/svlbitm.cxx +++ b/vcl/source/treelist/svlbitm.cxx @@ -333,8 +333,7 @@ SvLBoxButton::SvLBoxButton( SvLBoxButtonData* pBData ) } SvLBoxButton::SvLBoxButton() - : SvLBoxItem() - , isVis(false) + : isVis(false) , pData(nullptr) , nItemFlags(SvItemStateFlags::NONE) { @@ -472,8 +471,7 @@ SvLBoxContextBmp::SvLBoxContextBmp(const Image& aBmp1, const Image& aBmp2, } SvLBoxContextBmp::SvLBoxContextBmp() - :SvLBoxItem( ) - ,m_pImpl( new SvLBoxContextBmp_Impl ) + : m_pImpl( new SvLBoxContextBmp_Impl ) { m_pImpl->m_bExpanded = false; } diff --git a/vcl/source/uitest/logger.cxx b/vcl/source/uitest/logger.cxx index 6b3eed64f849..00d98a6cf779 100644 --- a/vcl/source/uitest/logger.cxx +++ b/vcl/source/uitest/logger.cxx @@ -63,8 +63,7 @@ vcl::Window* get_top_parent(vcl::Window* pWindow) } } UITestLogger::UITestLogger() - : maStream() - , mbValid(false) + : mbValid(false) { static const char* pFile = std::getenv("LO_COLLECT_UIINFO"); if (pFile) diff --git a/vcl/source/window/OptionalBox.cxx b/vcl/source/window/OptionalBox.cxx index 168da0474e7d..28055f7e210e 100644 --- a/vcl/source/window/OptionalBox.cxx +++ b/vcl/source/window/OptionalBox.cxx @@ -27,7 +27,6 @@ OptionalBox::OptionalBox(vcl::Window* pParent) : VclHBox(pParent) - , IPrioritable() , m_bInFullView(true) { } diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index a37175b93248..797740d127b8 100644 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -2399,8 +2399,7 @@ MenuBarWindow* MenuBar::getMenuBarWindow() } MenuBar::MenuBar() - : Menu(), - mbCloseBtnVisible(false), + : mbCloseBtnVisible(false), mbFloatBtnVisible(false), mbHideBtnVisible(false), mbDisplayable(true) @@ -2409,8 +2408,7 @@ MenuBar::MenuBar() } MenuBar::MenuBar( const MenuBar& rMenu ) - : Menu(), - mbCloseBtnVisible(false), + : mbCloseBtnVisible(false), mbFloatBtnVisible(false), mbHideBtnVisible(false), mbDisplayable(true) @@ -2706,7 +2704,6 @@ PopupMenu::PopupMenu() } PopupMenu::PopupMenu( const PopupMenu& rMenu ) - : Menu() { mpSalMenu = ImplGetSVData()->mpDefInst->CreateMenu(false, this); *this = rMenu; diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx index c69799ed1c4e..32a973a284ac 100644 --- a/vcl/source/window/printdlg.cxx +++ b/vcl/source/window/printdlg.cxx @@ -68,13 +68,9 @@ namespace { PrintDialog::PrintPreviewWindow::PrintPreviewWindow(PrintDialog* pDialog) : mpDialog(pDialog) - , maMtf() , maOrigSize( 10, 10 ) - , maPreviewSize() , mnDPIX(Application::GetDefaultDevice()->GetDPIX()) , mnDPIY(Application::GetDefaultDevice()->GetDPIY()) - , maPreviewBitmap() - , maReplacementString() , mbGreyscale( false ) { } diff --git a/vcl/source/window/tabpage.cxx b/vcl/source/window/tabpage.cxx index 08e0eebbe0a5..34f52d8b3bbd 100644 --- a/vcl/source/window/tabpage.cxx +++ b/vcl/source/window/tabpage.cxx @@ -95,7 +95,6 @@ void TabPage::ImplInitSettings() TabPage::TabPage( vcl::Window* pParent, WinBits nStyle ) : Window( WindowType::TABPAGE ) - , IContext() { ImplInit( pParent, nStyle ); } diff --git a/vcl/unx/generic/gdi/cairo_xlib_cairo.cxx b/vcl/unx/generic/gdi/cairo_xlib_cairo.cxx index 3f2698b60611..17b34442bd47 100644 --- a/vcl/unx/generic/gdi/cairo_xlib_cairo.cxx +++ b/vcl/unx/generic/gdi/cairo_xlib_cairo.cxx @@ -114,7 +114,6 @@ namespace cairo **/ X11Surface::X11Surface( const CairoSurfaceSharedPtr& pSurface ) : maSysData(), - mpPixmap(), mpSurface(pSurface) {} @@ -134,7 +133,6 @@ namespace cairo **/ X11Surface::X11Surface( const X11SysData& rSysData, int x, int y, int width, int height ) : maSysData(rSysData), - mpPixmap(), mpSurface( cairo_xlib_surface_create( static_cast<Display*>(rSysData.pDisplay), rSysData.hDrawable, @@ -159,7 +157,6 @@ namespace cairo X11Surface::X11Surface( const X11SysData& rSysData, const BitmapSystemData& rData ) : maSysData( rSysData ), - mpPixmap(), mpSurface( cairo_xlib_surface_create( static_cast<Display*>(rSysData.pDisplay), reinterpret_cast<Drawable>(rData.aPixmap), diff --git a/vcl/unx/generic/gdi/gdiimpl.cxx b/vcl/unx/generic/gdi/gdiimpl.cxx index 60cadef1ba0d..ceeaa1d55203 100644 --- a/vcl/unx/generic/gdi/gdiimpl.cxx +++ b/vcl/unx/generic/gdi/gdiimpl.cxx @@ -1635,8 +1635,7 @@ SystemDependentData_Triangulation::SystemDependentData_Triangulation( mfLineWidth(fLineWidth), meJoin(eJoin), meCap(eCap), - mfMiterMinimumAngle(fMiterMinimumAngle), - maStroke() + mfMiterMinimumAngle(fMiterMinimumAngle) { if(nullptr != pStroke) { diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx index e809923fb3bd..31567d63461a 100644 --- a/vcl/unx/generic/gdi/salgdi.cxx +++ b/vcl/unx/generic/gdi/salgdi.cxx @@ -68,7 +68,6 @@ X11SalGraphics::X11SalGraphics(): m_aXRenderPicture(0), mpClipRegion(nullptr), #if ENABLE_CAIRO_CANVAS - maClipRegion(), mnPenColor(SALCOLOR_NONE), mnFillColor(SALCOLOR_NONE), #endif // ENABLE_CAIRO_CANVAS diff --git a/vcl/unx/gtk3/gtkdata.cxx b/vcl/unx/gtk3/gtkdata.cxx index cb37d7764fd4..b5f49e821bd3 100644 --- a/vcl/unx/gtk3/gtkdata.cxx +++ b/vcl/unx/gtk3/gtkdata.cxx @@ -331,8 +331,6 @@ int GtkSalDisplay::CaptureMouse( SalFrame* pSFrame ) GtkSalData::GtkSalData( SalInstance *pInstance ) : GenericUnixSalData(pInstance) - , m_aDispatchMutex() - , m_aDispatchCondition() { m_pUserEvent = nullptr; } diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index e6620def5f3d..053bf5a0d607 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -1840,8 +1840,7 @@ class GtkOpenGLContext : public OpenGLContext public: GtkOpenGLContext() - : OpenGLContext() - , m_pGLArea(nullptr) + : m_pGLArea(nullptr) , m_pContext(nullptr) , m_nAreaFrameBuffer(0) , m_nFrameBuffer(0) diff --git a/vcl/unx/gtk3/gtksys.cxx b/vcl/unx/gtk3/gtksys.cxx index 41777f099f17..37e32b28b38e 100644 --- a/vcl/unx/gtk3/gtksys.cxx +++ b/vcl/unx/gtk3/gtksys.cxx @@ -35,7 +35,7 @@ SalSystem *GtkInstance::CreateSalSystem() return GtkSalSystem::GetSingleton(); } -GtkSalSystem::GtkSalSystem() : SalGenericSystem() +GtkSalSystem::GtkSalSystem() { mpDisplay = gdk_display_get_default(); #if !GTK_CHECK_VERSION(4, 0, 0) diff --git a/vcl/unx/gtk3/salnativewidgets-gtk.cxx b/vcl/unx/gtk3/salnativewidgets-gtk.cxx index 0f03b65053fc..c034c1135d89 100644 --- a/vcl/unx/gtk3/salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk3/salnativewidgets-gtk.cxx @@ -2823,8 +2823,7 @@ void GtkSalData::deInitNWF() } GtkSalGraphics::GtkSalGraphics( GtkSalFrame *pFrame, GtkWidget *pWindow ) - : SvpSalGraphics(), - mpFrame( pFrame ), + : mpFrame( pFrame ), mpWindow( pWindow ) { if (style_loaded)