sw/qa/uitest/writer_tests3/hyperlinkdialog.py | 8 ++++++++
1 file changed, 8 insertions(+)
New commits:
commit 82b81f00f2de2cf7b6440b1d23a0dd9bece45c48
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Tue Mar 30 15:11:55 2021 +0200
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Tue Mar 30 18:34:28 2021 +0200
For now, skip problematic test_tdf141166 also for --with-help
...similar to how it already got skipped with
10fbf2b80e11620f3fc1691aa7968e6d3d460db9 "Skip a problematic UITest for
--with-help=html/online". (And note how the check for "-DWITH_HELP" in
$SCPDEFS
would unfortunately also hit for the --with-help=html case, see
configure.ac, if
that were not already filtered with the preceding check, anyway.)
The better fix would arguably be to make the code close both the
"LibreOffice
Help" window and the "LibreOffice Help Not Installed" dialog, whichever
shows up
for a given configuration. But this temporary fix at least gets --with-help
builds like <https://ci.libreoffice.org/job/lo_ubsan/1961/> going again.
Change-Id: I9d9d6ffeb26a056fa3fe65085264d75822e7646c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113372
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
index 6e28a02b2dfa..d3554436a935 100644
--- a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
+++ b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
@@ -9,6 +9,7 @@
from uitest.framework import UITestCase
import os
+import re
import time
from uitest.uihelper.common import get_state_as_dict, type_text
from libreoffice.uno.propertyvalue import mkPropertyValues
@@ -88,6 +89,13 @@ class HyperlinkDialog(UITestCase):
# opened in the user's default browser):
if os.getenv('ENABLE_HTMLHELP') == 'TRUE':
return
+ # Skip this test for --with-help, as that would fail with a
+ # "uno.com.sun.star.uno.RuntimeException: Could not find child with
id: cancel" thrown from
+ # the below execute_blocking_action call, as it would open the
"LibreOffice Help" window
+ # instead of the apparently expected "LibreOffice Help Not Installed"
dialog that has a
+ # "Cancel" button:
+ if re.compile(r'-DWITH_HELP\b').search(os.getenv('SCPDEFS')):
+ return
self.ui_test.create_doc_in_start_center("writer")
xWriterDoc = self.xUITest.getTopFocusWindow()
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
