sc/source/ui/view/gridwin.cxx | 14 -------------- 1 file changed, 14 deletions(-)
New commits: commit 56e0bb77f8506abf9eb16f6a4ceff432190c81c4 Author: Caolán McNamara <caol...@redhat.com> AuthorDate: Sun Feb 28 19:14:24 2021 +0000 Commit: Caolán McNamara <caol...@redhat.com> CommitDate: Sun Feb 28 21:33:45 2021 +0100 remove unnecessary MouseButtonDown forward I don't see how this scenario can happen, and if it does, why we would want to send a MouseDown to the filter list. This hunk appears in the "initial import". There is a "On OS/2 when clicking next to the Popup menu..." comment on a different popup in this file so maybe there was some workaround for some condition that no longer happens. Change-Id: I15b4d57259047a20822685a00e1bf5b00aa21a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111715 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caol...@redhat.com> diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index 0fe1c7d357b5..e17a03de5971 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -1806,7 +1806,6 @@ void ScGridWindow::HandleMouseButtonDown( const MouseEvent& rMEvt, MouseEventSta // Scenario selection comes from MouseButtonDown: // The next MouseMove on the FilterBox is like a ButtonDown nMouseStatus = SC_GM_FILTER; - return; } @@ -2413,19 +2412,6 @@ void ScGridWindow::MouseMove( const MouseEvent& rMEvt ) return; } - if (nMouseStatus == SC_GM_FILTER && mpFilterBox) - { - Point aRelPos = mpFilterBox->ScreenToOutputPixel( OutputToScreenPixel( rMEvt.GetPosPixel() ) ); - if ( tools::Rectangle(Point(), mpFilterBox->GetOutputSizePixel()).IsInside(aRelPos) ) - { - nButtonDown = 0; - nMouseStatus = SC_GM_NONE; - ReleaseMouse(); - mpFilterBox->MouseButtonDown( MouseEvent( aRelPos, 1, MouseEventModifiers::SIMPLECLICK, MOUSE_LEFT ) ); - return; - } - } - bool bFormulaMode = pScMod->IsFormulaMode(); // next click -> reference if (bEEMouse && mrViewData.HasEditView( eWhich )) _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits