sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx | 5 +++++
1 file changed, 5 insertions(+)
New commits:
commit 3e1a46699e3b0868e2748f28e244b4d7de4fe775
Author: Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Fri Jan 29 12:42:09 2021 +0100
Commit: Caolán McNamara <caol...@redhat.com>
CommitDate: Fri Jan 29 21:10:09 2021 +0100
tdf#139996: do not crash if no slide is selected
when no slide is selected, SyncPageSelectionToDocument(xSelection).first
returns SAL_MAX_UINT16, which is greater than 0
Change-Id: I20225dc3c89a34358949f991d1548e11803c3131
Change-Id: I787d46ff97a6a1401c5bc4ffc136aefc4bbeea29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110154
Tested-by: Jenkins
Tested-by: Caolán McNamara <caol...@redhat.com>
Reviewed-by: Caolán McNamara <caol...@redhat.com>
diff --git a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx
b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx
index 05a571592ce3..25f3acafa9f0 100644
--- a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx
+++ b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx
@@ -797,6 +797,11 @@ void SlideSorterViewShell::ExecMovePageUp (SfxRequest&
/*rReq*/)
// SdDrawDocument MovePages is based on SdPage IsSelected, so
// transfer the SlideSorter selection to SdPages
sal_uInt16 firstSelectedPageNo =
SyncPageSelectionToDocument(xSelection).first;
+
+ // In case no slide is selected
+ if (firstSelectedPageNo == SAL_MAX_UINT16)
+ return;
+
// Now compute human page number from internal page number
firstSelectedPageNo = (firstSelectedPageNo - 1) / 2;
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
