chart2/source/controller/sidebar/ChartElementsPanel.cxx | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 121bbf069a0c2dd5990c8da89a3fc060ae83cb92
Author: Muhammet Kara <muhammet.k...@collabora.com>
AuthorDate: Wed Mar 18 13:56:43 2020 +0300
Commit: Muhammet Kara <muhammet.k...@collabora.com>
CommitDate: Fri Nov 13 16:31:58 2020 +0100
Sidebar tdf#92768: Fix title & subtitle checkboxes on the ChartDeck
Turns out the 2nd part of tdf#92768 was not implemented yet, so it is
still necessary to remove the title/subtitle for good, otherwise we set
the "Visibility" property, but nothing actually reads that when
rendering.
So the titles now work as they did before the regression. An uncheck action
removes the title/subtitle, and a check action just makes the existing
title/subtitle visible or creates a new one if it doesn't exist
Change-Id: I23122d1be2d95af878b824ba194bd1aeed5f4f89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90692
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
Reviewed-by: Andras Timar <andras.ti...@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105640
Reviewed-by: Muhammet Kara <muhammet.k...@collabora.com>
diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx
b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
index ac48b0a7e9cb..14fd14dad5d5 100644
--- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
@@ -592,7 +592,9 @@ void
ChartElementsPanel::setTitleVisible(TitleHelper::eTitleType eTitle, bool bV
}
else
{
- TitleHelper::hideTitle(eTitle, mxModel);
+ // TODO tdf#92768 use TitleHelper::hideTitle() here once there is
+ // rendering suport for the property "Visible"
+ TitleHelper::removeTitle(eTitle, mxModel);
}
}
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
