starmath/source/cursor.cxx | 1 -
starmath/visual-editor-todo | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 508daea752c1d9c44474abcee43168fc12657541
Author: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
AuthorDate: Fri Oct 23 15:23:14 2020 +0300
Commit: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
CommitDate: Fri Oct 23 16:20:20 2020 +0200
CreateTextFromNode is gone
Change-Id: Ia5786a642a4eea57eef224ace384cb3f9da9fe75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104728
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx
index 90bdf2207327..cdac53d4a234 100644
--- a/starmath/source/cursor.cxx
+++ b/starmath/source/cursor.cxx
@@ -1311,7 +1311,6 @@ void SmCursor::EndEdit(){
//Update the edit engine and text of the document
OUString formula;
SmNodeToTextVisitor(mpTree, formula);
- //mpTree->CreateTextFromNode(formula);
mpDocShell->maText = formula;
mpDocShell->GetEditEngine().QuickInsertText( formula, ESelection( 0, 0,
EE_PARA_ALL, EE_TEXTPOS_ALL ) );
mpDocShell->GetEditEngine().QuickFormatDoc();
diff --git a/starmath/visual-editor-todo b/starmath/visual-editor-todo
index 04dedae01699..65f2d7a7b6a0 100644
--- a/starmath/visual-editor-todo
+++ b/starmath/visual-editor-todo
@@ -15,8 +15,7 @@ Easy
1. SmGraphicWindow::KeyInput relies on comparison of char, a better way must
be available for CTRL+c
2. Code style (missing spaces, linebreaks and a few renames)
3. More documentation
-4. Remove the CreateTextFromNode methods and replace calls to it with
NodeToTextVisitor
-5. Extend NodeToTextVisitor to update token offsets so SmNode::GetRow and
SmNode::GetColumn will work.
+4. Extend NodeToTextVisitor to update token offsets so SmNode::GetRow and
SmNode::GetColumn will work.
(These methods can be used to enable synchronization of caret positions
between visual and non-visual editor).
Medium
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
