svl/source/items/slstitm.cxx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
New commits: commit 60723da529bbbac7067a86715752e4dbe7c6a291 Author: Caolán McNamara <caol...@redhat.com> AuthorDate: Fri Sep 25 15:08:51 2020 +0100 Commit: Christian Lohmaier <lohmaier+libreoff...@googlemail.com> CommitDate: Tue Sep 29 12:04:41 2020 +0200 Related: tdf#136985 SfxStringListItem::GetString() crash in empty case probably since... commit a573b8b21688d9681f4fa129ec37cf89954e9d1c Date: Sat May 21 16:14:56 2011 -0430 Replace List for std::vector in SfxStringListItem. Change-Id: I7060b5693ba08fa5f70cc5cb3ae1b7a4722a31a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103340 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.wegh...@posteo.de> (cherry picked from commit 7c8f997321e136208e8983ab6ad78cc33891125f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103571 Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org> Reviewed-by: Caolán McNamara <caol...@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com> diff --git a/svl/source/items/slstitm.cxx b/svl/source/items/slstitm.cxx index 05e5401db18e..54af346254d6 100644 --- a/svl/source/items/slstitm.cxx +++ b/svl/source/items/slstitm.cxx @@ -125,13 +125,12 @@ OUString SfxStringListItem::GetString() OUStringBuffer aStr; if ( mpList ) { - std::vector<OUString>::const_iterator iter = mpList->begin(); - for (;;) + for (auto iter = mpList->begin(), end = mpList->end(); iter != end;) { aStr.append(*iter); ++iter; - if (iter == mpList->end()) + if (iter == end) break; aStr.append("\r"); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits