On Wednesday 11 of April 2012, Matúš Kukan wrote: > Hi, > > I was investigating which dependency is missing for sometimes failing > i18npool_test_breakiterator and it is localedata_en. > > The dependency was often explicitly written in sc's makefiles (but > i18npool is not yet in tail_build, so not needed) and I think: > gb_CppunitTest_use_ure,foo => foo requires localedata_en > is true, so I created attached patch where the dependency is moved to > gb_CppunitTest_use_ure definition. > But I don't know if also the other implication is true: > gb_CppunitTest_use_ure,foo <= foo requires localedata_en > > I did not push yet but if no one is against I will do so soon because > it is safe and maybe also the right thing to do ?
As far as I can see, it is the i18npool library that dlopens localedata_en (i18npool/source/localedata/localedata.cxx), so I think the best way to express this dependency is to make i18npool depend on localedata_en (and localedata_es, localedata_euro and localedata_others). While this is not 100% technically correct, as it is only a runtime dependency and not a build dependency, there's no cycle and it should make sure that anything that does or will need localedata_en will have it ready. -- Lubos Lunak l.lu...@suse.cz _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
