sc/source/filter/inc/namebuff.hxx | 2 +-
sc/source/filter/lotus/lotus.cxx | 2 +-
sc/source/filter/lotus/tool.cxx | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit bee46dbfd9986f324f20852987c05ac4339d4d25
Author: Caolán McNamara <caol...@redhat.com>
AuthorDate: Sun Sep 13 17:02:35 2020 +0100
Commit: Caolán McNamara <caol...@redhat.com>
CommitDate: Sun Sep 13 22:12:32 2020 +0200
RangeNameBufferWK3 always dereferences its arg
Change-Id: I40c7c73d8d8fa2f9126f5895f8a6ed67a72bdf6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102592
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caol...@redhat.com>
diff --git a/sc/source/filter/inc/namebuff.hxx
b/sc/source/filter/inc/namebuff.hxx
index 9f3c66bfb1dd..b56fee1d169e 100644
--- a/sc/source/filter/inc/namebuff.hxx
+++ b/sc/source/filter/inc/namebuff.hxx
@@ -97,7 +97,7 @@ private:
std::vector<Entry> maEntries;
public:
- RangeNameBufferWK3(const ScDocument* pDoc);
+ RangeNameBufferWK3(const ScDocument& rDoc);
~RangeNameBufferWK3();
void Add( const ScDocument* pDoc, const OUString&
rName, const ScComplexRefData& rCRD );
inline void Add( const ScDocument* pDoc, const OUString&
rName, const ScRange& aScRange );
diff --git a/sc/source/filter/lotus/lotus.cxx b/sc/source/filter/lotus/lotus.cxx
index b900c22a58b4..cbdb43e6be33 100644
--- a/sc/source/filter/lotus/lotus.cxx
+++ b/sc/source/filter/lotus/lotus.cxx
@@ -94,7 +94,7 @@ LotusContext::LotusContext(ScDocument* pDocP,
rtl_TextEncoding eQ)
, maRangeNames()
, eFirstType( Lotus123Typ::X)
, eActType( Lotus123Typ::X)
- , pRngNmBffWK3( new RangeNameBufferWK3(pDocP) )
+ , pRngNmBffWK3( new RangeNameBufferWK3(*pDocP) )
, maAttrTable( *this )
{
}
diff --git a/sc/source/filter/lotus/tool.cxx b/sc/source/filter/lotus/tool.cxx
index 891eaaa556e0..dd868ee98996 100644
--- a/sc/source/filter/lotus/tool.cxx
+++ b/sc/source/filter/lotus/tool.cxx
@@ -426,8 +426,8 @@ void LotusRangeList::Append( const ScDocument* pDoc,
std::unique_ptr<LotusRange>
nIdCnt++;
}
-RangeNameBufferWK3::RangeNameBufferWK3(const ScDocument* pDoc)
- : pScTokenArray( new ScTokenArray(*pDoc) )
+RangeNameBufferWK3::RangeNameBufferWK3(const ScDocument& rDoc)
+ : pScTokenArray( new ScTokenArray(rDoc) )
{
nIntCount = 1;
}
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
