[Libreoffice-commits] core.git: config_host/config_skia.h.in vcl/skia

[Luboš Luňák (via logerrit)]

 config_host/config_skia.h.in |    1 -
 vcl/skia/gdiimpl.cxx         |   15 ++-------------
 vcl/skia/salbmp.cxx          |    3 ---
 vcl/skia/win/gdiimpl.cxx     |    2 +-
 4 files changed, 3 insertions(+), 18 deletions(-)

New commits:
commit 52a889241313da27eaeefc6493f8ee663abcb5dd
Author:     Luboš Luňák <l.lu...@collabora.com>
AuthorDate: Wed Jun 17 13:01:45 2020 +0200
Commit:     Luboš Luňák <l.lu...@collabora.com>
CommitDate: Wed Jun 17 13:03:19 2020 +0200

    remove outdated Skia todo comments
    
    Change-Id: Ib2a9e4c25421c20e52ee65b2ec8fb3a190bcb75b

diff --git a/config_host/config_skia.h.in b/config_host/config_skia.h.in
index f262161b1a46..5e24def6beaf 100644
--- a/config_host/config_skia.h.in
+++ b/config_host/config_skia.h.in
@@ -25,7 +25,6 @@ are the same.
 #define SKIA_USE_BITMAP32 0
 
 
-/* TODO SKIA check all these */
 
 #define SK_SUPPORT_GPU 1
 
diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 7acb0f35d07f..c9e420057fd4 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -881,20 +881,17 @@ bool SkiaSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectToDev
 
 bool SkiaSalGraphicsImpl::drawPolyLineBezier(sal_uInt32, const SalPoint*, 
const PolyFlags*)
 {
-    // TODO?
     return false;
 }
 
 bool SkiaSalGraphicsImpl::drawPolygonBezier(sal_uInt32, const SalPoint*, const 
PolyFlags*)
 {
-    // TODO?
     return false;
 }
 
 bool SkiaSalGraphicsImpl::drawPolyPolygonBezier(sal_uInt32, const sal_uInt32*,
                                                 const SalPoint* const*, const 
PolyFlags* const*)
 {
-    // TODO?
     return false;
 }
 
@@ -1250,11 +1247,7 @@ void SkiaSalGraphicsImpl::invert(sal_uInt32 nPoints, 
const SalPoint* pPointArray
     invert(aPolygon, eFlags);
 }
 
-bool SkiaSalGraphicsImpl::drawEPS(long, long, long, long, void*, sal_uInt32)
-{
-    // TODO?
-    return false;
-}
+bool SkiaSalGraphicsImpl::drawEPS(long, long, long, long, void*, sal_uInt32) { 
return false; }
 
 // Create SkImage from a bitmap and possibly an alpha mask (the usual VCL 
one-minus-alpha),
 // with the given target size. Result will be possibly cached, unless disabled.
@@ -1440,11 +1433,7 @@ bool SkiaSalGraphicsImpl::drawAlphaRect(long nX, long 
nY, long nWidth, long nHei
     return true;
 }
 
-bool SkiaSalGraphicsImpl::drawGradient(const tools::PolyPolygon&, const 
Gradient&)
-{
-    // TODO?
-    return false;
-}
+bool SkiaSalGraphicsImpl::drawGradient(const tools::PolyPolygon&, const 
Gradient&) { return false; }
 
 static double toRadian(int degree10th) { return (3600 - degree10th) * M_PI / 
1800.0; }
 static double toCos(int degree10th) { return 
SkScalarCos(toRadian(degree10th)); }
diff --git a/vcl/skia/salbmp.cxx b/vcl/skia/salbmp.cxx
index 1bf0f77bfc2a..0474b4859405 100644
--- a/vcl/skia/salbmp.cxx
+++ b/vcl/skia/salbmp.cxx
@@ -164,7 +164,6 @@ bool SkiaSalBitmap::Create(const SalBitmap& rSalBmp, 
sal_uInt16 nNewBitCount)
 
 bool SkiaSalBitmap::Create(const 
css::uno::Reference<css::rendering::XBitmapCanvas>&, Size&, bool)
 {
-    // TODO?
     return false;
 }
 
@@ -276,7 +275,6 @@ bool SkiaSalBitmap::GetSystemData(BitmapSystemData&)
 #ifdef DBG_UTIL
     assert(mWriteAccessCount == 0);
 #endif
-    // TODO?
     return false;
 }
 
@@ -336,7 +334,6 @@ bool SkiaSalBitmap::Replace(const Color&, const Color&, 
sal_uInt8)
 #ifdef DBG_UTIL
     assert(mWriteAccessCount == 0);
 #endif
-    // TODO?
     return false;
 }
 
diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index 6129c8e266da..94879d14bcac 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -324,7 +324,7 @@ sk_sp<SkImage> SkiaCompatibleDC::getAsImageDiff(const 
SkiaCompatibleDC& white) c
     // keep the alpha channel as transparent. Therefore the alpha is actually 
computed
     // from the difference in the premultiplied red channels when drawn one 
black and on white.
     // Alpha is computed as "alpha = 1.0 - abs(black.red - white.red)".
-    // TODO I doubt this can be done using Skia, so do it manually here. 
Fortunately
+    // I doubt this can be done using Skia, so do it manually here. Fortunately
     // the bitmaps should be fairly small and are cached.
     uint32_t* dest = tmpBitmap.getAddr32(0, 0);
     assert(dest == tmpBitmap.getPixels());
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits