drawinglayer/source/processor2d/vclpixelprocessor2d.cxx | 4 ++++
vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx | 4 ++++
2 files changed, 8 insertions(+)
New commits:
commit cefad27ee85486b01cf600c08371a651787dadc2
Author: Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Fri May 29 19:26:08 2020 +0300
Commit: Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Sat May 30 10:06:32 2020 +0200
Add TODOs
Change-Id: I6ab5840487f7676d5070ea4be00272f13dd47f96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95162
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>
diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index 8d217dcf18db..3a57695f81e0 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -1022,6 +1022,10 @@ void VclPixelProcessor2D::processGlowPrimitive2D(const
primitive2d::GlowPrimitiv
void VclPixelProcessor2D::processSoftEdgePrimitive2D(
const primitive2d::SoftEdgePrimitive2D& rCandidate)
{
+ // TODO: don't limit the object at view range. This is needed to not blur
objects at window
+ // borders, where they don't end. Ideally, process the full object once at
maximal reasonable
+ // resolution, and store the resulting alpha mask in primitive's cache;
then reuse it later,
+ // applying the transform.
basegfx::B2DRange aRange(rCandidate.getB2DRange(getViewInformation2D()));
aRange.transform(maCurrentTransformation);
basegfx::B2DVector aRadiusVector(rCandidate.getRadius(), 0);
diff --git a/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx
b/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx
index fe4f63f90d16..5cf24ec2f101 100644
--- a/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx
+++ b/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx
@@ -19,6 +19,10 @@
#include <algorithm>
+/* TODO: Use round kernel instead of square one.
+ This would make the result more natural, e.g. not making rounded square out
of circle.
+ */
+
namespace
{
struct FilterSharedData
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
