sc/source/ui/view/gridwin.cxx | 3 ---
1 file changed, 3 deletions(-)
New commits:
commit bda60c9b1ca6a0fbfde9f3428489f33729cc81f1
Author: Tor Lillqvist <t...@iki.fi>
AuthorDate: Thu May 28 12:53:16 2020 +0300
Commit: Tor Lillqvist <t...@collabora.com>
CommitDate: Thu May 28 16:11:42 2020 +0200
tdf#128502: Remove assertions that fire for gtktiledviewer on two docs
If you run gtktiledviewer so that it opens a spreadsheet and a text
document these assertions would fire.
In each case the assertion is followed by code that just returns if
the asserted condition doesn't hold, so it is unlikely that this
change will break anything.
There sure will be a lot of further changes needed to make such a use
case work. (For starters, editing either of the two documents does not
work.) But let's do it step by step.
Change-Id: I4063dbbcac7c77b57e1f4cb3f05bd5096c08c0fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95037
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <t...@collabora.com>
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index bb55a7433cfb..e7ba202632a2 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5708,7 +5708,6 @@ void ScGridWindow::notifyKitCellViewCursor(const
SfxViewShell* pForShell) const
if (mpOOCursors) // cf. getCellCursor above
{
auto pForTabView = dynamic_cast<const ScTabViewShell *>(pForShell);
- assert(pForTabView);
if (!pForTabView)
return;
aCursor = pForTabView->GetViewData().describeCellCursorAt(
@@ -5745,7 +5744,6 @@ void ScGridWindow::updateKitOtherCursors() const
it = SfxViewShell::GetNext(*it))
{
auto pOther = dynamic_cast<const ScTabViewShell *>(it);
- assert(pOther);
if (!pOther)
continue;
const ScGridWindow *pGrid = pOther->GetViewData().GetActiveWin();
@@ -5970,7 +5968,6 @@ void ScGridWindow::updateOtherKitSelections() const
it = SfxViewShell::GetNext(*it))
{
auto pOther = dynamic_cast<const ScTabViewShell *>(it);
- assert(pOther);
if (!pOther)
return;
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
