cypress_test/integration_tests/mobile/calc/number_format_spec.js | 14 ++++------ cypress_test/integration_tests/mobile/writer/shape_properties_spec.js | 5 +-- 2 files changed, 8 insertions(+), 11 deletions(-)
New commits: commit 04388d764bd7f75de9e516dd76e6bd76d2f94d2c Author: Tamás Zolnai <tamas.zol...@collabora.com> AuthorDate: Thu Apr 16 10:44:25 2020 +0200 Commit: Tamás Zolnai <tamas.zol...@collabora.com> CommitDate: Thu Apr 16 11:16:00 2020 +0200 cypress: mobile: update checkbox related code snipets. These checks were not actually unreliable, but the checkbox handling code was changed. Change-Id: I4b3f7dc161d9a774466cdfb6bca49de8d1311714 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92339 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zol...@collabora.com> diff --git a/cypress_test/integration_tests/mobile/calc/number_format_spec.js b/cypress_test/integration_tests/mobile/calc/number_format_spec.js index dbf8f7ddc..20d7ecebe 100644 --- a/cypress_test/integration_tests/mobile/calc/number_format_spec.js +++ b/cypress_test/integration_tests/mobile/calc/number_format_spec.js @@ -392,15 +392,14 @@ describe('Apply number formatting.', function() { it('Apply red color for negative numbers.', function() { // Check default value cy.get('#negativenumbersred input') - .should('not.have.attr', 'checked', 'checked'); + .should('not.have.prop', 'checked', true); // Change the option cy.get('#negativenumbersred input') .click(); - // TODO - //cy.get('#negativenumbersred input') - // .should('have.attr', 'checked', 'checked'); + cy.get('#negativenumbersred input') + .should('have.prop', 'checked', true); calcHelper.copyContentToClipboard(); @@ -414,15 +413,14 @@ describe('Apply number formatting.', function() { it('Add thousands separator.', function() { // Check default value cy.get('#thousandseparator input') - .should('not.have.attr', 'checked', 'checked'); + .should('not.have.prop', 'checked', true); // Change the option cy.get('#thousandseparator input') .click(); - // TODO - //cy.get('#thousandseparator input') - // .should('have.attr', 'checked', 'checked'); + cy.get('#thousandseparator input') + .should('have.prop', 'checked', true); calcHelper.copyContentToClipboard(); diff --git a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js index a8c7dd0f5..8304162d8 100644 --- a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js +++ b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js @@ -130,9 +130,8 @@ describe('Change shape properties via mobile wizard.', function() { cy.get('#ratio #ratio') .click(); - // TODO: unreliable - //cy.get('#ratio #ratio') - // .should('have.attr', 'checked', 'checked'); + cy.get('#ratio #ratio') + .should('have.prop', 'checked', true); // Change height cy.get('#selectheight .spinfield') _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits