Hey, 2012/3/16 Markus Mohrhard <markus.mohrh...@googlemail.com>: > Hello Michael, > >> On Tue, 2012-03-13 at 01:41 +0100, Markus Mohrhard wrote: >>> calc. The problem is that we should not shrink the area already in >>> ScTransferObj. We should wait until we need to export the data and >>> limit this to the text export. Please test it especially in the >>> context of n#677811. >> >> I see one of Rainer's favorite bugs already has a patch; but - since >> you've pushed it to master, were you asking for review for -3-5 ? > > I was asking for review and Muthu or Kohei to check that the private > Novell bug is not affected by this patch since I this time chose a > more aggressive fix to finally eliminate all problems around > copy/paste & dnd to internal and external applications. > >> re-titling to that for now ... > > Oh I always thought that [REVIEW] is the correct tag for current > stable branch and [PATCH] for master but if not I will adapt this. > >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a26fe4a39b6f3b2af269b801340c32c28806250 >> >> It looks reasonable to me, if so :-) >> > > According to Muthu I might need a follow-up patch for n#677811 because > Outlook seems to use the HTML export and not the text export. >
So with http://cgit.freedesktop.org/libreoffice/core/commit/?id=0ee518863337fba9bce019e05e24f527617a4321 we should now have solved all problems at once. We now allow to copy/paste the content to external applications and shrink the area in case of text unconditionally and in case of HTML in case of a whole selected row or column. I think this solution is sane and safe. We no longer mess around with the internal copy/paste document and only adjust the cases that are really useful and needed. It would be good to get these two patches into 3.5.2 since they solve a really annoying bug. Regards, Markus _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
