[Libreoffice-commits] core.git: xmlscript/source

[Samuel Mehrbrodt (via logerrit)]

 xmlscript/source/xmldlg_imexp/xmldlg_export.cxx |    4 +++-
 xmlscript/source/xmldlg_imexp/xmldlg_import.cxx |   11 +++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 6d9cf22b2239611a6612a7855f8a701ed723cbd4
Author:     Samuel Mehrbrodt <samuel.mehrbr...@cib.de>
AuthorDate: Mon Feb 24 23:38:40 2020 +0100
Commit:     Samuel Mehrbrodt <samuel.mehrbr...@cib.de>
CommitDate: Wed Feb 26 06:40:23 2020 +0100

    tdf#130793 Fix import/export of image URLs
    
    Change-Id: I329af3b0d5a81d9f31def9c2ad861d0e83e3714c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89388
    Tested-by: Jenkins
    Reviewed-by: Samuel Mehrbrodt <samuel.mehrbr...@cib.de>

diff --git a/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx 
b/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
index 1e192e3c387d..413facd87652 100644
--- a/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
+++ b/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
@@ -738,7 +738,9 @@ void ElementDescriptor::readImageOrGraphicAttr(OUString 
const & rAttrName)
             }
         }
     }
-    else if (beans::PropertyState_DEFAULT_VALUE != 
_xPropState->getPropertyState("ImageURL"))
+    // tdf#130793 Above fails if the dialog is not part of a document. Export 
the ImageURL then.
+    if (sURL.isEmpty()
+        && beans::PropertyState_DEFAULT_VALUE != 
_xPropState->getPropertyState("ImageURL"))
     {
         _xProps->getPropertyValue("ImageURL") >>= sURL;
     }
diff --git a/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx 
b/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx
index 791976b55c5e..5aa953cd6562 100644
--- a/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx
+++ b/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx
@@ -880,6 +880,17 @@ bool ImportContext::importGraphicOrImageProperty(
                 return true;
             }
         }
+        else if (!sURL.isEmpty())
+        {
+            // tdf#130793 Above fails if the dialog is not part of a document.
+            // In this case we need to set the ImageURL.
+            Reference<beans::XPropertySet> xProps = getControlModel();
+            if (xProps.is())
+            {
+                xProps->setPropertyValue("ImageURL", makeAny(sURL));
+                return true;
+            }
+        }
     }
     return false;
 }
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits