sw/qa/extras/ooxmlexport/ooxmlexport14.cxx | 12 ++++++++++++
sw/source/filter/ww8/wrtw8sty.cxx | 28 ++++++++++++++++------------
2 files changed, 28 insertions(+), 12 deletions(-)
New commits:
commit f0decd9c932b50eddeecd49a6ee44182e78be938
Author: Miklos Vajna <vmik...@collabora.com>
AuthorDate: Fri Feb 7 16:06:19 2020 +0100
Commit: Miklos Vajna <vmik...@collabora.com>
CommitDate: Fri Feb 7 20:57:55 2020 +0100
DOCX export: fix handling of section starts that originally had page margins
This is similar to commit 26f2a9e1a10a22e864e71ee7c94934821703e021 (DOCX
export: fix handling of section starts that originally had headers,
2020-02-06), except here the top margin has to taken from that follow
page style, not the header.
Without this, it can happen that the page number in the original Writer
doc model and the exported Word result do not match.
This required reworking WriteNextStyleHeaderFooter(), which assumed that
the header/footer status is already calculated by the time its called.
But the page margin code runs earlier, so we need to make that decision
earlier, even when the header/footer status is not yet calculated.
Change-Id: Ife7396603702d2048d544aa46f96acfa337a041a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88211
Reviewed-by: Miklos Vajna <vmik...@collabora.com>
Tested-by: Jenkins
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 7817c26ad5ac..3bdae52c4d65 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -485,6 +485,18 @@ DECLARE_OOXMLEXPORT_TEST(testContSectBreakHeaderFooter,
"cont-sect-break-header-
// - Expected: Header, section 2
// - Actual : First page header, section 2
// i.e. both the header and the footer on page 3 was wrong.
+
+ // Additional problem: top margin on page 3 was wrong.
+ if (mbExported)
+ {
+ xmlDocPtr pXml = parseExport("word/document.xml");
+ // Without the accompanying fix in place, this test would have failed
with:
+ // - Expected: 2200
+ // - Actual : 2574
+ // i.e. the top margin on page 3 was too large and now matches the
value from the input
+ // document.
+ assertXPath(pXml, "/w:document/w:body/w:sectPr/w:pgMar", "top",
"2200");
+ }
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx
b/sw/source/filter/ww8/wrtw8sty.cxx
index d13e9b384a1b..49b1edc946af 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -1522,11 +1522,11 @@ void WW8Export::WriteHeadersFooters( sal_uInt8
nHeadFootFlags,
namespace
{
/**
- * Find a node near the section start that has a page break, it may have a
follow header/footer for
- * us.
+ * Determines if the continuous section break we start should use page style
properties (header,
+ * footer, margins) from the next page style of the previous section.
*/
-bool WriteNextStyleHeaderFooter(sal_uInt8 nBreakCode, sal_uInt8 nHeadFootFlags,
- const SwPageDesc* pPd, const WW8_SepInfo&
rSepInfo)
+bool UsePrevSectionNextStyle(sal_uInt8 nBreakCode, const SwPageDesc* pPd,
+ const WW8_SepInfo& rSepInfo)
{
if (nBreakCode != 0)
{
@@ -1534,12 +1534,6 @@ bool WriteNextStyleHeaderFooter(sal_uInt8 nBreakCode,
sal_uInt8 nHeadFootFlags,
return false;
}
- if (nHeadFootFlags != 0)
- {
- // Would write some header/footer anyway.
- return false;
- }
-
if (!pPd->GetFollow())
{
// Page style has no follow style.
@@ -1623,6 +1617,7 @@ void MSWordExportBase::SectionProperties( const
WW8_SepInfo& rSepInfo, WW8_PdAtt
bool bOutPgDscSet = true, bLeftRightPgChain = false, bOutputStyleItemSet =
false;
bool bEnsureHeaderFooterWritten = rSepInfo.pSectionFormat &&
rSepInfo.bIsFirstParagraph;
const SwFrameFormat* pPdFormat = &pPd->GetMaster();
+ bool bUsePrevSectionNextStyle = false;
if ( rSepInfo.pSectionFormat )
{
// if pSectionFormat is set, then there is a SectionNode
@@ -1648,6 +1643,15 @@ void MSWordExportBase::SectionProperties( const
WW8_SepInfo& rSepInfo, WW8_PdAtt
// produce Itemset, which inherits PgDesk-Attr-Set:
// as child also the parent is searched if 'deep'-OutputItemSet
const SfxItemSet* pPdSet = &pPdFormat->GetAttrSet();
+
+ bUsePrevSectionNextStyle = GetExportFormat() == ExportFormat::DOCX
+ && UsePrevSectionNextStyle(nBreakCode,
pPd, rSepInfo);
+ if (bUsePrevSectionNextStyle)
+ {
+ // Take page margins from the previous section's next style.
+ pPdSet = &pPd->GetFollow()->GetMaster().GetAttrSet();
+ }
+
SfxItemSet aSet( *pPdSet->GetPool(), pPdSet->GetRanges() );
aSet.SetParent( pPdSet );
@@ -1840,9 +1844,9 @@ void MSWordExportBase::SectionProperties( const
WW8_SepInfo& rSepInfo, WW8_PdAtt
const SwTextNode *pOldPageRoot = GetHdFtPageRoot();
SetHdFtPageRoot( rSepInfo.pPDNd ? rSepInfo.pPDNd->GetTextNode() : nullptr
);
- if (GetExportFormat() == ExportFormat::DOCX
- && WriteNextStyleHeaderFooter(nBreakCode, nHeadFootFlags, pPd,
rSepInfo))
+ if (bUsePrevSectionNextStyle && nHeadFootFlags == 0)
{
+ // Take headers/footers from the previous section's next style.
pPdFormat = &pPd->GetFollow()->GetMaster();
MSWordSections::SetHeaderFlag(nHeadFootFlags, *pPdFormat,
WW8_HEADER_ODD);
MSWordSections::SetFooterFlag(nHeadFootFlags, *pPdFormat,
WW8_FOOTER_ODD);
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
