sc/source/ui/inc/tabview.hxx | 12 +++---------
sc/source/ui/view/tabview3.cxx | 11 +++++++++++
2 files changed, 14 insertions(+), 9 deletions(-)
New commits:
commit 961f7e8ec8ef188c361b2b20b60b95e78ecccd33
Author: Luboš Luňák <l.lu...@collabora.com>
AuthorDate: Sat Feb 1 10:33:23 2020 +0100
Commit: Luboš Luňák <l.lu...@collabora.com>
CommitDate: Sat Feb 1 20:12:07 2020 +0100
move internal inline function from .hxx to .cxx
This normally wouldn't make a difference, but it does when building
with Clang's -fmodules-codegen to collect duplicated templates,
inlines, etc. into extra .o file. The inline calling the template
is emitted in that .o, but the template is defined only in the .cxx
and not referenced from it, so it's never emitted.
Change-Id: I8b49030f2be6146ca1e2cd5e35734c0db6cca394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87798
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lu...@collabora.com>
diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index e12e53f65473..82b46318235b 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -100,15 +100,9 @@ public:
~ScExtraEditViewManager();
- void Add(SfxViewShell* pViewShell, ScSplitPos eWhich)
- {
- Apply<Adder>(pViewShell, eWhich);
- }
-
- void Remove(SfxViewShell* pViewShell, ScSplitPos eWhich)
- {
- Apply<Remover>(pViewShell, eWhich);
- }
+ void Add(SfxViewShell* pViewShell, ScSplitPos eWhich);
+
+ void Remove(SfxViewShell* pViewShell, ScSplitPos eWhich);
private:
template<ModifierTagType ModifierTag>
diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index a14fb12b3fc1..fa68182b2399 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -99,6 +99,17 @@ ScExtraEditViewManager::~ScExtraEditViewManager()
DBG_ASSERT(nTotalWindows == 0, "ScExtraEditViewManager dtor: some out
window has not yet been removed!");
}
+inline void ScExtraEditViewManager::Add(SfxViewShell* pViewShell, ScSplitPos
eWhich)
+{
+ Apply<Adder>(pViewShell, eWhich);
+}
+
+inline void ScExtraEditViewManager::Remove(SfxViewShell* pViewShell,
ScSplitPos eWhich)
+{
+ Apply<Remover>(pViewShell, eWhich);
+}
+
+
template<ScExtraEditViewManager::ModifierTagType ModifierTag>
void ScExtraEditViewManager::Apply(SfxViewShell* pViewShell, ScSplitPos eWhich)
{
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
