sd/source/filter/eppt/eppt.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
New commits: commit 7e2ba14567d2c7f7a657c159d9d02a4ca4543e36 Author: Julien Nabet <[email protected]> AuthorDate: Mon Oct 7 21:28:42 2019 +0200 Commit: Julien Nabet <[email protected]> CommitDate: Tue Oct 8 07:22:44 2019 +0200 Add some doc and fix comment in eppt (sd) See https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-ppt/6be79dde-33c1-4c1b-8ccc-4b2301c08662 " 2.6.1: A - fAutoAdvance (1 bit): A bit that specifies whether to automatically advance to the next slide during a slide show based on timing information on the slide. B - fWillSkipBuilds (1 bit): A bit that specifies whether to display animations during a slide show. C - fUseSlideRange (1 bit): A bit that specifies whether to display only the slide range specified by the startSlide and endSlide fields during a slide show. D - fDocUseNamedShow (1 bit): A bit that specifies whether the slides shown during a slide show are from the named show identified by namedShow. It MUST be ignored if fUseSlideRange is TRUE. E - fBrowseMode (1 bit): A bit that specifies whether the slide show is presented in a way optimized for browsing. If fBrowseMode is TRUE, fKioskMode MUST be FALSE. F - fKioskMode (1 bit): A bit that specifies whether the slide show is presented in a way optimized to run at a kiosk. If fKioskMode is TRUE, fBrowseMode MUST be FALSE. G - fWillSkipNarration (1 bit): A bit that specifies whether to play slide audio narrations during a slide show. H - fLoopContinuously (1 bit): A bit that specifies whether to restart the slide show at the beginning after advancing from the last slide. I - fHideScrollBar (1 bit): A bit that specifies whether to display the navigational scroll bar during a slide show. " So yes, "IsEndless" corresponds to "fLoopContinuously" Document "Skip narration" + "show scrollbar" corresponds to Bit 8 (the contrary of "fHideScrollBar") so since this the Bit 8 of nFlags isn't set, it's always to 0, so we always show scrollbar Change-Id: Ifb4f62a9f52cdafac9f788f4d6d1deb0cf1b8efa Reviewed-on: https://gerrit.libreoffice.org/80415 Reviewed-by: Julien Nabet <[email protected]> Tested-by: Julien Nabet <[email protected]> diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx index c648cf612c7b..246be042c7db 100644 --- a/sd/source/filter/eppt/eppt.cxx +++ b/sd/source/filter/eppt/eppt.cxx @@ -759,8 +759,9 @@ bool PPTWriter::ImplCreateDocument() // Bit 3 Use named show // Bit 4 Browse mode on // Bit 5 Kiosk mode on + // Bit 6 Skip narration // Bit 7 loop continuously - // Bit ? show scrollbar + // Bit 8 show scrollbar if ( ImplGetPropertyValue( "CustomShow" ) ) { @@ -796,7 +797,7 @@ bool PPTWriter::ImplCreateDocument() nFlags |= 1; } - if ( ImplGetPropertyValue( "IsEndless" ) ) // the correct name would be IsNotEndless: WTF? + if ( ImplGetPropertyValue( "IsEndless" ) ) { bool bBool = false; mAny >>= bBool; _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
