compilerplugins/clang/virtualdead.results | 13 ++++++++++++-
dbaccess/source/ui/misc/ToolBoxHelper.cxx | 1 -
include/dbaccess/ToolBoxHelper.hxx | 6 ------
include/vcl/tabpage.hxx | 1 -
reportdesign/source/ui/dlg/Condition.cxx | 4 ----
reportdesign/source/ui/dlg/Condition.hxx | 6 ------
reportdesign/source/ui/inc/AddField.hxx | 9 ---------
vcl/source/control/tabctrl.cxx | 1 -
vcl/source/control/wizardmachine.cxx | 5 -----
vcl/source/window/tabpage.cxx | 4 ----
10 files changed, 12 insertions(+), 38 deletions(-)
New commits:
commit 9db8406b839df8a892d025e054e818def4a60edc
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Thu Oct 3 14:51:14 2019 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Thu Oct 3 16:34:45 2019 +0200
loplugin:virtualdead
Change-Id: I86bae18ed2682871032aeb2a178f49f3e4601129
Reviewed-on: https://gerrit.libreoffice.org/80129
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/compilerplugins/clang/virtualdead.results
b/compilerplugins/clang/virtualdead.results
index 70b36c5e14a9..1e8d8a886cad 100644
--- a/compilerplugins/clang/virtualdead.results
+++ b/compilerplugins/clang/virtualdead.results
@@ -31,6 +31,9 @@ Gui/qaccessible.h:613
Gui/qaccessible.h:619
void QAccessibleTableInterface::modelChange(class
QAccessibleTableModelChangeEvent *,)
empty
+include/basegfx/utils/unopolypolygon.hxx:97
+ void basegfx::unotools::UnoPolyPolygon::modifying()const
+ empty
include/canvas/base/bitmapcanvasbase.hxx:80
unsigned char canvas::BitmapCanvasBase::hasAlpha()
1
@@ -52,6 +55,9 @@ include/canvas/base/graphicdevicebase.hxx:319
include/connectivity/sdbcx/IRefreshable.hxx:31
void connectivity::sdbcx::IRefreshableGroups::refreshGroups()
empty
+include/dbaccess/ToolBoxHelper.hxx:56
+ void dbaui::OToolBoxHelper::setImageList(short,)
+ empty
include/filter/msfilter/msdffimp.hxx:546
_Bool SvxMSDffManager::ShapeHasText(unsigned long,unsigned long,)const
1
@@ -67,6 +73,9 @@ include/svl/svdde.hxx:239
include/svl/svdde.hxx:241
_Bool DdeTopic::MakeItem(const class rtl::OUString &,)
0
+include/svl/svdde.hxx:244
+ _Bool DdeTopic::StartAdviseLoop()
+ 0
include/svtools/unoevent.hxx:199
unsigned short SvEventDescriptor::getMacroItemWhich()const
108
@@ -82,7 +91,9 @@ include/unotools/desktopterminationobserver.hxx:35
include/vbahelper/vbahelperinterface.hxx:77
int InheritedHelperInterfaceImpl::getCreator()
1400204879
- unknown2
+include/vcl/tabpage.hxx:51
+ void TabPage::DeactivatePage()
+ empty
sc/source/core/opencl/formulagroupcl.cxx:1059
void
sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class
std::__cxx11::basic_stringstream<char> &,)
empty
diff --git a/dbaccess/source/ui/misc/ToolBoxHelper.cxx
b/dbaccess/source/ui/misc/ToolBoxHelper.cxx
index 23dc9ddb2ff0..3fc009dee348 100644
--- a/dbaccess/source/ui/misc/ToolBoxHelper.cxx
+++ b/dbaccess/source/ui/misc/ToolBoxHelper.cxx
@@ -52,7 +52,6 @@ namespace dbaui
if ( nCurSymbolsSize != m_nSymbolsSize )
{
m_nSymbolsSize = nCurSymbolsSize;
- setImageList(m_nSymbolsSize);
Size aTbOldSize = m_pToolBox->GetSizePixel();
adjustToolBoxSize(m_pToolBox);
diff --git a/include/dbaccess/ToolBoxHelper.hxx
b/include/dbaccess/ToolBoxHelper.hxx
index 527197b43de5..75f6dd094445 100644
--- a/include/dbaccess/ToolBoxHelper.hxx
+++ b/include/dbaccess/ToolBoxHelper.hxx
@@ -49,12 +49,6 @@ namespace dbaui
*/
virtual void resizeControls(const Size& _rDiff) = 0;
- /** will be called when the image list needs to change
- @param _eSymbolsSize
- <svtools/imgdef.hxx>
- */
- virtual void setImageList(sal_Int16 _eSymbolsSize) = 0;
-
/** only the member will be set, derived classes can override
this function and do what need to be done.
@param _pTB
diff --git a/include/vcl/tabpage.hxx b/include/vcl/tabpage.hxx
index 9af5c1062954..17270d9b6c0f 100644
--- a/include/vcl/tabpage.hxx
+++ b/include/vcl/tabpage.hxx
@@ -48,7 +48,6 @@ public:
virtual void DataChanged( const DataChangedEvent& rDCEvt ) override;
virtual void ActivatePage();
- virtual void DeactivatePage();
//To-Do, consider inheriting from VclContainer
virtual void SetPosSizePixel(const Point& rNewPos, const Size&
rNewSize) override;
diff --git a/reportdesign/source/ui/dlg/Condition.cxx
b/reportdesign/source/ui/dlg/Condition.cxx
index 878c31748cf0..1504ea8f7d8a 100644
--- a/reportdesign/source/ui/dlg/Condition.cxx
+++ b/reportdesign/source/ui/dlg/Condition.cxx
@@ -267,10 +267,6 @@ void Condition::ApplyCommand( sal_uInt16 _nCommandId,
const NamedColor& rNamedCo
m_rAction.applyCommand( m_nCondIndex, _nCommandId, rNamedColor.first );
}
-void Condition::setImageList(sal_Int16 /*_eBitmapSet*/)
-{
-}
-
void Condition::resizeControls(const Size& /*_rDiff*/)
{
}
diff --git a/reportdesign/source/ui/dlg/Condition.hxx
b/reportdesign/source/ui/dlg/Condition.hxx
index d94804d35c24..d8a03ac82f57 100644
--- a/reportdesign/source/ui/dlg/Condition.hxx
+++ b/reportdesign/source/ui/dlg/Condition.hxx
@@ -125,12 +125,6 @@ namespace rptui
virtual ~Condition() override;
virtual void dispose() override;
- /** will be called when the id of the image list needs to change.
- @param _eBitmapSet
- <svtools/imgdef.hxx>
- */
- virtual void setImageList(sal_Int16 _eBitmapSet) override;
-
/** will be called when the controls need to be resized.
*/
virtual void resizeControls(const Size& _rDiff) override;
diff --git a/reportdesign/source/ui/inc/AddField.hxx
b/reportdesign/source/ui/inc/AddField.hxx
index 13b73b44e14a..b122bb3012d7 100644
--- a/reportdesign/source/ui/inc/AddField.hxx
+++ b/reportdesign/source/ui/inc/AddField.hxx
@@ -95,15 +95,6 @@ public:
css::uno::Sequence< css::beans::PropertyValue >
getSelectedFieldDescriptors();
- /** will be called when the id of the image list needs to change.
- @param _eBitmapSet
- <svtools/imgdef.hxx>
- */
- virtual void setImageList(sal_Int16) override
- {
- //to-do, remove
- }
-
/** will be called when the controls need to be resized.
*/
virtual void resizeControls(const Size& _rDiff) override;
diff --git a/vcl/source/control/tabctrl.cxx b/vcl/source/control/tabctrl.cxx
index 522bf6e66310..736579277bbe 100644
--- a/vcl/source/control/tabctrl.cxx
+++ b/vcl/source/control/tabctrl.cxx
@@ -660,7 +660,6 @@ void TabControl::ImplChangeTabPage( sal_uInt16 nId,
sal_uInt16 nOldId )
{
if ( mbRestoreHelpId )
pCtrlParent->SetHelpId( OString() );
- pOldPage->DeactivatePage();
}
if ( pPage )
diff --git a/vcl/source/control/wizardmachine.cxx
b/vcl/source/control/wizardmachine.cxx
index c049f9a3e987..b5f1afd5b0c8 100644
--- a/vcl/source/control/wizardmachine.cxx
+++ b/vcl/source/control/wizardmachine.cxx
@@ -321,8 +321,6 @@ namespace vcl
return;
TabPage* pOldTabPage = mpCurTabPage;
- if ( pOldTabPage )
- pOldTabPage->DeactivatePage();
mpCurTabPage = pTabPage;
if ( pTabPage )
@@ -582,9 +580,6 @@ namespace vcl
bool RoadmapWizard::Finish( long nResult )
{
- if ( mpCurTabPage )
- mpCurTabPage->DeactivatePage();
-
if ( IsInExecute() )
EndDialog( nResult );
else if ( GetStyle() & WB_CLOSEABLE )
diff --git a/vcl/source/window/tabpage.cxx b/vcl/source/window/tabpage.cxx
index 825aec67e617..d09ef10d542d 100644
--- a/vcl/source/window/tabpage.cxx
+++ b/vcl/source/window/tabpage.cxx
@@ -172,10 +172,6 @@ void TabPage::ActivatePage()
{
}
-void TabPage::DeactivatePage()
-{
-}
-
Size TabPage::GetOptimalSize() const
{
if (isLayoutEnabled(this))
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
