desktop/source/minidump/minidump.cxx | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 044a683e6c8f864d46fe8ebe3ef5c757cbea30a6
Author: Juergen Funk <juergen.funk...@cib.de>
AuthorDate: Wed Sep 25 12:09:21 2019 +0200
Commit: Juergen Funk (CIB) <juergen.funk...@cib.de>
CommitDate: Tue Oct 1 10:35:16 2019 +0200
desktop: proper error checking for crashreport ini reading
Change-Id: I1107304a0e3f482b6a7e6110006c2f26b9cb0778
Reviewed-on: https://gerrit.libreoffice.org/79603
Reviewed-by: Juergen Funk (CIB) <juergen.funk...@cib.de>
Tested-by: Juergen Funk (CIB) <juergen.funk...@cib.de>
diff --git a/desktop/source/minidump/minidump.cxx
b/desktop/source/minidump/minidump.cxx
index 85b2374e4ad7..f9666bff5998 100644
--- a/desktop/source/minidump/minidump.cxx
+++ b/desktop/source/minidump/minidump.cxx
@@ -23,7 +23,9 @@ static std::map<std::string, std::string>
readStrings(std::istream& file)
{
std::map<std::string, std::string> parameters;
- while (!file.eof())
+ // when file is not readable, the status eof would not be set
+ // better test of state is okay
+ while (file)
{
std::string line;
std::getline(file, line);
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
