On Mon, 2012-02-27 at 16:15 +0000, Michael Meeks wrote: > On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote: > > On 27.02.2012 19:01, Michael Meeks wrote: > > > Having said that I'm not hyper-happy with not initialising the vector's > > > contents - don't we really want: > > > > > > std::vector<sal_uInt16> aWish( aTablCols.Count() + 1, 0 ), > > > aMins( aTabCols.Count() + 1, 0 ); > ... > > > — otherwise, the storage for the object is zero-initialized. > > Fair enough :-) Patch looks great then, one more ack needed for 3.5.1.
I'm happy with this, so pushed now. Re Max and so forth, original conversion should probably have use the Max(255, number) as an input into vector.reserve and then it would have been a 1-for-1 conversion wrt. the push_backs. A good catch. C. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
