net/Socket.hpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit d832fb3c9d1a89287daaf5cd082a594061a3283b
Author: Michael Meeks <michael.me...@collabora.com>
AuthorDate: Sat Mar 30 11:30:39 2019 +0000
Commit: Michael Meeks <michael.me...@collabora.com>
CommitDate: Sat Mar 30 17:50:59 2019 +0100
Crop socket buffer removal to socket buffer size & warn.
Change-Id: I734b4682941d71eee02a25aab61c8e4353a11718
Reviewed-on: https://gerrit.libreoffice.org/69948
Reviewed-by: Michael Meeks <michael.me...@collabora.com>
Tested-by: Michael Meeks <michael.me...@collabora.com>
diff --git a/net/Socket.hpp b/net/Socket.hpp
index e27dc6df0..1a074ce2d 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -932,7 +932,11 @@ public:
/// Remove the first @count bytes from input buffer
void eraseFirstInputBytes(size_t count)
{
- _inBuffer.erase(_inBuffer.begin(), _inBuffer.begin() + count);
+ size_t toErase = std::min(count, _inBuffer.size());
+ if (toErase < count)
+ LOG_ERR("#" << getFD() << ": attempted to remove: " << count << "
which is > size: " << _inBuffer.size() << " clamped to " << toErase);
+ if (toErase > 0)
+ _inBuffer.erase(_inBuffer.begin(), _inBuffer.begin() + count);
}
/// Detects if we have an HTTP header in the provided message and
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
